fix: resolve IllegalPluginAccessException on disable, support custom hologram locations centered on blocks, and bump version to 1.0.8

Author: synkfr

gradle.properties

@@ -1,3 +1,3 @@
 group=dev.velmax
-version=1.0.7
+version=1.0.8
 description=A modern, high-performance King of the Hill plugin for PaperMC 1.21+

src/main/java/dev/velmax/velkoth/arena/Arena.java

@@ -2,6 +2,7 @@
 
 import dev.velmax.velkoth.arena.region.Region;
 import dev.velmax.velkoth.reward.Reward;
+import org.bukkit.Location;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -20,6 +21,7 @@ public final class Arena {
     private List<Reward> rewards;
     private int graceperiod;
     private int maxScore;
+    private Location hologramLocation;
 
     public Arena(String id, String displayName, Region region, int captureTime,
             CaptureMode captureMode, int gracePeriod, int maxScore) {
@@ -102,6 +104,14 @@ public void setMaxScore(int maxScore) {
         this.maxScore = maxScore;
     }
 
+    public Location hologramLocation() {
+        return hologramLocation;
+    }
+
+    public void setHologramLocation(Location hologramLocation) {
+        this.hologramLocation = hologramLocation;
+    }
+
     /**
      * Mode of capture for this arena.
      */

src/main/java/dev/velmax/velkoth/command/KothCommand.java

@@ -22,6 +22,8 @@
 import org.bukkit.persistence.PersistentDataType;
 import org.incendo.cloud.execution.ExecutionCoordinator;
 import org.incendo.cloud.paper.PaperCommandManager;
+import org.bukkit.Location;
+import org.incendo.cloud.parser.standard.DoubleParser;
 import org.incendo.cloud.parser.standard.EnumParser;
 import org.incendo.cloud.parser.standard.IntegerParser;
 import org.incendo.cloud.parser.standard.StringParser;
@@ -158,6 +160,23 @@ private void registerCommands() {
                 .required("seconds", IntegerParser.integerParser())
                 .handler(ctx -> handleSetGrace(ctx.sender().source(), ctx.get("arena"), ctx.get("seconds"))));
 
+        manager.command(setBuilder.literal("hologram")
+                .required("arena", StringParser.stringParser(), arenaSuggestions)
+                .senderType(PlayerSource.class)
+                .handler(ctx -> handleSetHologramHere(ctx.sender().source(), ctx.get("arena"))));
+
+        manager.command(setBuilder.literal("hologram")
+                .required("arena", StringParser.stringParser(), arenaSuggestions)
+                .literal("reset")
+                .handler(ctx -> handleSetHologramReset(ctx.sender().source(), ctx.get("arena"))));
+
+        manager.command(setBuilder.literal("hologram")
+                .required("arena", StringParser.stringParser(), arenaSuggestions)
+                .required("x", DoubleParser.doubleParser())
+                .required("y", DoubleParser.doubleParser())
+                .required("z", DoubleParser.doubleParser())
+                .handler(ctx -> handleSetHologramCoords(ctx.sender().source(), ctx.get("arena"), ctx.get("x"), ctx.get("y"), ctx.get("z"))));
+
         // ── Reward ──
         var rewardBuilder = base.literal("reward").permission("velkoth.admin");
 
@@ -490,6 +509,67 @@ private void handleSetGrace(CommandSender sender, String arenaId, int seconds) {
                 .replace("<value>", seconds + "s"));
     }
 
+    private void handleSetHologramHere(Player player, String arenaId) {
+        Arena arena = plugin.getArenaManager().getArena(arenaId);
+        if (arena == null) {
+            sendPrefixed(player, plugin.getMessages().getArenaNotFound().replace("<arena>", arenaId));
+            return;
+        }
+
+        Location loc = player.getLocation();
+        arena.setHologramLocation(loc);
+        plugin.getArenaManager().saveArenas();
+
+        // Update the hologram location immediately if it is active
+        plugin.getDisplayManager().getHologramManager().updateLocation(arena);
+
+        String coordsStr = String.format("%.1f, %.1f, %.1f", loc.getX(), loc.getY(), loc.getZ());
+        sendPrefixed(player, plugin.getMessages().getArenaModified()
+                .replace("<arena>", arena.id())
+                .replace("<property>", "hologram-location")
+                .replace("<value>", coordsStr));
+    }
+
+    private void handleSetHologramReset(CommandSender sender, String arenaId) {
+        Arena arena = plugin.getArenaManager().getArena(arenaId);
+        if (arena == null) {
+            sendPrefixed(sender, plugin.getMessages().getArenaNotFound().replace("<arena>", arenaId));
+            return;
+        }
+
+        arena.setHologramLocation(null);
+        plugin.getArenaManager().saveArenas();
+
+        // Update the hologram location immediately if it is active
+        plugin.getDisplayManager().getHologramManager().updateLocation(arena);
+
+        sendPrefixed(sender, plugin.getMessages().getArenaModified()
+                .replace("<arena>", arena.id())
+                .replace("<property>", "hologram-location")
+                .replace("<value>", "default"));
+    }
+
+    private void handleSetHologramCoords(CommandSender sender, String arenaId, double x, double y, double z) {
+        Arena arena = plugin.getArenaManager().getArena(arenaId);
+        if (arena == null) {
+            sendPrefixed(sender, plugin.getMessages().getArenaNotFound().replace("<arena>", arenaId));
+            return;
+        }
+
+        Location loc = new Location(arena.region().getWorld(), x, y, z);
+        arena.setHologramLocation(loc);
+        plugin.getArenaManager().saveArenas();
+
+        // Update the hologram location immediately if it is active
+        plugin.getDisplayManager().getHologramManager().updateLocation(arena);
+
+        String coordsStr = String.format("%.1f, %.1f, %.1f", x, y, z);
+        sendPrefixed(sender, plugin.getMessages().getArenaModified()
+                .replace("<arena>", arena.id())
+                .replace("<property>", "hologram-location")
+                .replace("<value>", coordsStr));
+    }
+
     // ── Reward ──
 
     private void handleRewardAdd(CommandSender sender, String arenaId, String rewardStr) {
@@ -590,6 +670,9 @@ private void handleHelp(CommandSender sender) {
         sendPrefixed(sender, " <gold>/koth set time <arena> <seconds></gold>");
         sendPrefixed(sender, " <gold>/koth set score <arena> <maxScore></gold>");
         sendPrefixed(sender, " <gold>/koth set grace <arena> <seconds></gold>");
+        sendPrefixed(sender, " <gold>/koth set hologram <arena></gold>");
+        sendPrefixed(sender, " <gold>/koth set hologram <arena> <x> <y> <z></gold>");
+        sendPrefixed(sender, " <gold>/koth set hologram <arena> reset</gold>");
         sendPrefixed(sender, "");
         sendPrefixed(sender, "<gold><bold>Reward Commands</bold></gold>");
         sendPrefixed(sender, " <gold>/koth reward add <arena> <reward></gold>");

src/main/java/dev/velmax/velkoth/config/ArenaConfig.java

@@ -72,6 +72,9 @@ public static class ArenaEntry extends OkaeriConfig {
                 "give %player% diamond 3",
                 "eco give %player% 500");
 
+        @Comment("Custom hologram location [x, y, z]")
+        private List<Double> hologramLocation = null;
+
         // Getters & Setters
         public String getDisplayName() {
             return displayName;
@@ -192,5 +195,13 @@ public List<String> getRewards() {
         public void setRewards(List<String> rewards) {
             this.rewards = rewards;
         }
+
+        public List<Double> getHologramLocation() {
+            return hologramLocation;
+        }
+
+        public void setHologramLocation(List<Double> hologramLocation) {
+            this.hologramLocation = hologramLocation;
+        }
     }
 }

src/main/java/dev/velmax/velkoth/display/HologramManager.java

@@ -39,9 +39,18 @@ public void spawn(Arena arena) {
         if (!plugin.getPluginConfig().getDisplay().isHologramEnabled())
             return;
 
-        Location center = arena.region().getCenter();
-        // Adjust Y offset as configured (e.g. +3 blocks above center)
-        center.add(0, plugin.getPluginConfig().getDisplay().getHologramYOffset(), 0);
+        Location center;
+        if (arena.hologramLocation() != null) {
+            center = arena.hologramLocation().clone();
+        } else {
+            center = arena.region().getCenter();
+            // Adjust Y offset as configured (e.g. +3 blocks above center)
+            center.add(0, plugin.getPluginConfig().getDisplay().getHologramYOffset(), 0);
+        }
+
+        // Always center to the block (X.5, Z.5)
+        center.setX(center.getBlockX() + 0.5);
+        center.setZ(center.getBlockZ() + 0.5);
 
         if (center.getWorld() == null)
             return;
@@ -68,15 +77,25 @@ public void spawn(Arena arena) {
         });
     }
 
-    /**
-     * Safely removes the hologram for an arena.
-     * 
-     * @param arena the arena
-     */
     public void remove(Arena arena) {
         TextDisplay display = holograms.remove(arena);
         if (display != null && display.isValid()) {
-            display.getScheduler().run(plugin, scheduledTask -> display.remove(), null);
+            if (plugin.isEnabled()) {
+                display.getScheduler().run(plugin, scheduledTask -> display.remove(), null);
+            } else {
+                display.remove();
+            }
+        }
+    }
+
+
+    /**
+     * Updates the location of the hologram dynamically if it is active.
+     */
+    public void updateLocation(Arena arena) {
+        if (holograms.containsKey(arena)) {
+            remove(arena);
+            spawn(arena);
         }
     }
 

src/main/java/dev/velmax/velkoth/manager/ArenaManager.java

@@ -94,6 +94,12 @@ public void saveArenas() {
         }
         arena.setRewards(rewards);
 
+        // Parse custom hologram location
+        if (ae.getHologramLocation() != null && ae.getHologramLocation().size() == 3) {
+            List<Double> loc = ae.getHologramLocation();
+            arena.setHologramLocation(new org.bukkit.Location(world, loc.get(0), loc.get(1), loc.get(2)));
+        }
+
         return arena;
     }
 
@@ -163,6 +169,14 @@ private ArenaConfig.ArenaEntry serializeArena(Arena arena) {
         }
         ae.setRewards(rewardStrings);
 
+        // Serialize custom hologram location
+        if (arena.hologramLocation() != null) {
+            org.bukkit.Location loc = arena.hologramLocation();
+            ae.setHologramLocation(List.of(loc.getX(), loc.getY(), loc.getZ()));
+        } else {
+            ae.setHologramLocation(null);
+        }
+
         return ae;
     }
 

tasks/todo.md

@@ -0,0 +1,26 @@
+# Tasks for Hologram Positioning and Commands
+
+Implement centering holograms on blocks, adding commands to modify and change hologram positions, and verifying optimal performance using Display entities (TextDisplay).
+
+## Todo List
+- [x] Add `hologramLocation` field (nullable Location) in `Arena.java` and its getter/setter
+- [x] Add `hologramLocation` field (List<Double>) in `ArenaConfig.ArenaEntry` and its getter/setter
+- [x] Update serialization/deserialization logic in `ArenaManager.java` to support custom hologram location
+- [x] Modify `HologramManager.java` to:
+  - Spawn hologram at custom location if set, otherwise fallback to region center + Y offset
+  - Always center X/Z coordinates of hologram location to block center (X.5, Z.5)
+- [x] Add commands in `KothCommand.java` under `/koth set hologram`:
+  - `/koth set hologram <arena>` (sets to current player position)
+  - `/koth set hologram <arena> <x> <y> <z>` (sets to custom coordinates)
+  - `/koth set hologram <arena> reset` (clears the custom location)
+- [x] Add support to update active holograms immediately when their position changes
+
+## Review Section
+- Custom `hologramLocation` has been added to `Arena` and `ArenaConfig.ArenaEntry`.
+- Deserialization and serialization logic have been fully integrated in `ArenaManager`.
+- Spawning logic in `HologramManager` now checks for a custom location first and falls back to the region center + Y offset if not set.
+- Both custom and default hologram positions are automatically centered to the block's horizontal middle (`X.5`, `Z.5`).
+- TextDisplay (Display Entity) is used for high-performance hologram rendering.
+- New commands registered: `/koth set hologram <arena>`, `/koth set hologram <arena> <x> <y> <z>`, and `/koth set hologram <arena> reset`.
+- If an arena is active, any modification to its hologram position immediately updates the active hologram in the game.
+- Verified build and compilation successfully with Java 21 toolchain.