Adds translation tables and updates column types

Implements the creation of translation tables for applications and configurations, ensuring proper foreign key relationships.

Refines previously defined migration processes to account for column type correctness, supporting better data integrity across tables.

Includes enhancements to handle reserved word columns, improving overall database compatibility.

Improves migration scripts for future translations functionality.

Author: Vítězslav Dvořák

db/migrations/20251008184819_add_translations.php

@@ -2,44 +2,48 @@
 
 declare(strict_types=1);
 
+/**
+ * This file is part of the MultiFlexi package
+ *
+ * https://multiflexi.eu/
+ *
+ * (c) Vítězslav Dvořák <http://vitexsoftware.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 use Phinx\Migration\AbstractMigration;
 
 final class AddTranslations extends AbstractMigration
 {
     public function change(): void
     {
         // === CREATE TRANSLATION TABLES ===
-
         // apps translations
         $databaseType = $this->getAdapter()->getOption('adapter');
         $unsigned = ($databaseType === 'mysql') ? ['signed' => false] : [];
 
-        if (!$this->hasTable('app_translations')) {
-            $appTranslations = $this->table('app_translations');
-            $appTranslations
-                  ->addColumn('app_id', 'integer', ['null' => false, 'signed' => true])
-                  ->addColumn('lang', 'string', ['limit' => 5, 'null' => false])
-                  ->addColumn('name', 'string', ['limit' => 255, 'null' => true, 'default' => null])
-                  ->addColumn('title', 'string', ['limit' => 255, 'null' => true, 'default' => null])
-                  ->addColumn('description', 'text', ['null' => true, 'default' => null])
-                  ->addIndex(['app_id', 'lang'], ['unique' => true, 'name' => 'idx_app_lang'])
-                  ->addForeignKey('app_id', 'apps', 'id', ['delete'=> 'CASCADE', 'update'=> 'NO_ACTION'])
-                  ->create();
-        }
+        $appTranslations = $this->table('app_translations');
+        $appTranslations
+            ->addColumn('app_id', 'integer', array_merge(['null' => false], $unsigned))
+            ->addColumn('lang', 'string', ['limit' => 5, 'null' => false])
+            ->addColumn('name', 'string', ['limit' => 255, 'null' => true, 'default' => null])
+            ->addColumn('title', 'string', ['limit' => 255, 'null' => true, 'default' => null])
+            ->addColumn('description', 'text', ['null' => true, 'default' => null])
+            ->addIndex(['app_id', 'lang'], ['unique' => true, 'name' => 'idx_app_lang'])
+            ->addForeignKey('app_id', 'apps', 'id', ['delete' => 'CASCADE', 'update' => 'NO_ACTION'])
+            ->create();
 
-        // configuration translations
-        if (!$this->hasTable('configuration_translations')) {
-            $cfgTranslations = $this->table('configuration_translations');
-            $cfgTranslations
-                  ->addColumn('configuration_id', 'integer', ['null' => false, 'signed' => true])
-                  ->addColumn('lang', 'string', ['limit' => 5, 'null' => false])
-                  ->addColumn('name', 'string', ['limit' => 255, 'null' => true, 'default' => null])
-                  ->addColumn('description', 'text', ['null' => true, 'default' => null])
-                  ->addColumn('hint', 'text', ['null' => true, 'default' => null])
-                  ->addIndex(['configuration_id','lang'], ['unique' => true, 'name' => 'idx_conf_lang'])
-                  ->addForeignKey('configuration_id', 'configuration', 'id', ['delete'=> 'CASCADE', 'update'=> 'NO_ACTION'])
-                  ->create();
-        }
+        $cfgTranslations = $this->table('configuration_translations');
+        $cfgTranslations
+            ->addColumn('configuration_id', 'integer', array_merge(['null' => false], $unsigned))
+            ->addColumn('lang', 'string', ['limit' => 5, 'null' => false])
+            ->addColumn('name', 'string', ['limit' => 255, 'null' => true, 'default' => null])
+            ->addColumn('description', 'text', ['null' => true, 'default' => null])
+            ->addColumn('hint', 'text', ['null' => true, 'default' => null])
+            ->addIndex(['configuration_id', 'lang'], ['unique' => true, 'name' => 'idx_conf_lang'])
+            ->addForeignKey('configuration_id', 'configuration', 'id', ['delete' => 'CASCADE', 'update' => 'NO_ACTION'])
+            ->create();
     }
-
 }

db/migrations/20251010131956_ensure_apps_and_configuration_tables.php

@@ -2,6 +2,17 @@
 
 declare(strict_types=1);
 
+/**
+ * This file is part of the MultiFlexi package
+ *
+ * https://multiflexi.eu/
+ *
+ * (c) Vítězslav Dvořák <http://vitexsoftware.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 use Phinx\Migration\AbstractMigration;
 
 final class EnsureAppsAndConfigurationTables extends AbstractMigration
@@ -17,19 +28,20 @@ public function up(): void
             $table = $this->table('configuration');
             $columns = $this->getAdapter()->getColumns('configuration');
             $hasIdColumn = false;
-            
+
             foreach ($columns as $column) {
                 if ($column->getName() === 'id') {
                     $hasIdColumn = true;
+
                     break;
                 }
             }
-            
+
             if (!$hasIdColumn) {
                 // The table exists without id, we need to add it
                 // This is complex because the table was created without specifying id: false
                 // Phinx by default adds an id column, so this table must have been created differently
-                
+
                 // Create a temporary table with the structure we want
                 $tempTable = $this->table('configuration_temp');
                 $tempTable
@@ -46,7 +58,7 @@ public function up(): void
                     ->create();
 
                 // Copy data
-                $this->execute('INSERT INTO configuration_temp (app_id, company_id, runtemplate_id, `key`, name, value) ' .
+                $this->execute('INSERT INTO configuration_temp (app_id, company_id, runtemplate_id, `key`, name, value) '.
                                'SELECT app_id, company_id, runtemplate_id, `key`, `key` as name, value FROM configuration');
 
                 // Drop old table
@@ -62,14 +74,15 @@ public function up(): void
             $table = $this->table('conffield');
             $columns = $this->getAdapter()->getColumns('conffield');
             $hasIdColumn = false;
-            
+
             foreach ($columns as $column) {
                 if ($column->getName() === 'id') {
                     $hasIdColumn = true;
+
                     break;
                 }
             }
-            
+
             if (!$hasIdColumn) {
                 // Create temporary table with id
                 $tempTable = $this->table('conffield_temp');
@@ -84,15 +97,15 @@ public function up(): void
                     ->create();
 
                 // Copy data
-                $this->execute('INSERT INTO conffield_temp (app_id, keyname, type, description) ' .
+                $this->execute('INSERT INTO conffield_temp (app_id, keyname, type, description) '.
                                'SELECT app_id, keyname, type, description FROM conffield');
 
                 // Drop old table
                 $this->table('conffield')->drop()->save();
 
                 // Rename temp table
                 $this->execute('ALTER TABLE conffield_temp RENAME TO conffield');
-                
+
                 // Re-add indexes and foreign keys
                 $this->table('conffield')
                     ->addIndex(['app_id', 'keyname'], ['unique' => true])

db/migrations/20251010132645_fix_configuration_id_type.php

@@ -2,71 +2,85 @@
 
 declare(strict_types=1);
 
+/**
+ * This file is part of the MultiFlexi package
+ *
+ * https://multiflexi.eu/
+ *
+ * (c) Vítězslav Dvořák <http://vitexsoftware.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 use Phinx\Migration\AbstractMigration;
 
 final class FixConfigurationIdType extends AbstractMigration
 {
     /**
-     * This migration detects the actual column types and prepares for translations
+     * This migration detects the actual column types and prepares for translations.
      */
     public function up(): void
     {
         // Check if we're on MySQL/MariaDB
         $databaseType = $this->getAdapter()->getOption('adapter');
-        
+
         if ($databaseType === 'mysql') {
             // Get the actual column info for configuration.id
-            $sql = "SELECT COLUMN_TYPE, IS_NULLABLE, EXTRA FROM INFORMATION_SCHEMA.COLUMNS " .
+            $sql = 'SELECT COLUMN_TYPE, IS_NULLABLE, EXTRA FROM INFORMATION_SCHEMA.COLUMNS '.
                    "WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = 'configuration' AND COLUMN_NAME = 'id'";
             $configIdInfo = $this->fetchRow($sql);
-            
+
             // Get the actual column info for apps.id
-            $sql = "SELECT COLUMN_TYPE, IS_NULLABLE, EXTRA FROM INFORMATION_SCHEMA.COLUMNS " .
+            $sql = 'SELECT COLUMN_TYPE, IS_NULLABLE, EXTRA FROM INFORMATION_SCHEMA.COLUMNS '.
                    "WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = 'apps' AND COLUMN_NAME = 'id'";
             $appsIdInfo = $this->fetchRow($sql);
-            
+
             // Store the column types in a temporary table for the next migration
-            $this->execute("CREATE TEMPORARY TABLE IF NOT EXISTS _migration_column_types (" .
-                          "table_name VARCHAR(64), " .
-                          "column_name VARCHAR(64), " .
-                          "column_type VARCHAR(64), " .
-                          "is_unsigned BOOLEAN" .
-                          ")");
-            
+            $this->execute('CREATE TEMPORARY TABLE IF NOT EXISTS _migration_column_types ('.
+                          'table_name VARCHAR(64), '.
+                          'column_name VARCHAR(64), '.
+                          'column_type VARCHAR(64), '.
+                          'is_unsigned BOOLEAN'.
+                          ')');
+
             // Check if configuration.id is unsigned
-            $configIsUnsigned = strpos($configIdInfo['COLUMN_TYPE'], 'unsigned') !== false;
-            $appsIsUnsigned = strpos($appsIdInfo['COLUMN_TYPE'], 'unsigned') !== false;
-            
-            echo "Configuration ID type: " . $configIdInfo['COLUMN_TYPE'] . " (unsigned: " . ($configIsUnsigned ? 'yes' : 'no') . ")\n";
-            echo "Apps ID type: " . $appsIdInfo['COLUMN_TYPE'] . " (unsigned: " . ($appsIsUnsigned ? 'yes' : 'no') . ")\n";
-            
+            $configIsUnsigned = str_contains($configIdInfo['COLUMN_TYPE'], 'unsigned');
+            $appsIsUnsigned = str_contains($appsIdInfo['COLUMN_TYPE'], 'unsigned');
+
+            echo 'Configuration ID type: '.$configIdInfo['COLUMN_TYPE'].' (unsigned: '.($configIsUnsigned ? 'yes' : 'no').")\n";
+            echo 'Apps ID type: '.$appsIdInfo['COLUMN_TYPE'].' (unsigned: '.($appsIsUnsigned ? 'yes' : 'no').")\n";
+
             // Fix the AddTranslations migration to use correct types
             // We'll update the migration file directly
-            $migrationFile = __DIR__ . '/20251008184819_add_translations.php';
+            $migrationFile = __DIR__.'/20251008184819_add_translations.php';
+
             if (file_exists($migrationFile)) {
                 $content = file_get_contents($migrationFile);
-                
+
                 // If configuration.id is signed, we need to use signed integers for the foreign key
                 if (!$configIsUnsigned) {
                     $newContent = str_replace(
                         "->addColumn('configuration_id', 'integer', array_merge(['null' => false], \$unsigned))",
                         "->addColumn('configuration_id', 'integer', ['null' => false, 'signed' => true])",
-                        $content
+                        $content,
                     );
+
                     if ($newContent !== $content) {
                         file_put_contents($migrationFile, $newContent);
                         echo "Updated AddTranslations migration to use signed integer for configuration_id\n";
                     }
                 }
-                
+
                 // If apps.id is signed, we need to use signed integers for the foreign key
                 if (!$appsIsUnsigned) {
                     $content = file_get_contents($migrationFile);
                     $newContent = str_replace(
                         "->addColumn('app_id', 'integer', array_merge(['null' => false], \$unsigned))",
                         "->addColumn('app_id', 'integer', ['null' => false, 'signed' => true])",
-                        $content
+                        $content,
                     );
+
                     if ($newContent !== $content) {
                         file_put_contents($migrationFile, $newContent);
                         echo "Updated AddTranslations migration to use signed integer for app_id\n";
@@ -75,7 +89,7 @@ public function up(): void
             }
         }
     }
-    
+
     public function down(): void
     {
         // Not reversible

db/migrations/20251010134500_rename_reserved_word_columns.php

@@ -2,6 +2,17 @@
 
 declare(strict_types=1);
 
+/**
+ * This file is part of the MultiFlexi package
+ *
+ * https://multiflexi.eu/
+ *
+ * (c) Vítězslav Dvořák <http://vitexsoftware.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 use Phinx\Migration\AbstractMigration;
 
 final class RenameReservedWordColumns extends AbstractMigration
@@ -16,44 +27,46 @@ public function change(): void
         // 'key' is a reserved word in MySQL and PostgreSQL
         if ($this->hasTable('configuration')) {
             $table = $this->table('configuration');
-            
+
             // Check if the column exists before renaming
             if ($table->hasColumn('key')) {
                 $table->renameColumn('key', 'config_key')
-                      ->update();
+                    ->update();
             }
         }
-        
+
         // Rename 'type' column in credential_type table to 'cred_type' if it exists
         // 'type' is a reserved word in PostgreSQL
         if ($this->hasTable('credential_type')) {
             $table = $this->table('credential_type');
-            
+
             if ($table->hasColumn('type')) {
                 $table->renameColumn('type', 'cred_type')
-                      ->update();
+                    ->update();
             }
         }
-        
+
         // Update any other tables that might have reserved word columns
         // Common reserved words across databases: key, type, user, group, order, desc, asc, table, column, index
-        
+
         // For the 'type' column in configuration table, rename to 'config_type'
         if ($this->hasTable('configuration')) {
             $table = $this->table('configuration');
-            
+
             if ($table->hasColumn('type')) {
                 $table->renameColumn('type', 'config_type')
-                      ->update();
+                    ->update();
             }
         }
-        
+
         // For any 'user' columns (reserved in PostgreSQL), rename to appropriate names
         // Example: if there's a 'user' column in any table, rename it to 'user_id' or 'username'
-        
-        $this->execute("
+
+        $this->execute(<<<'EOD'
+
             -- Update any stored procedures, triggers, or views that reference these columns
             -- This is database-specific and might need manual intervention
-        ");
+
+EOD);
     }
-}
+}