Use data provider for various forms of meta queries.

Author: peterwilsoncc

tests/phpunit/tests/query/metaQuery.php

@@ -739,6 +739,8 @@ public function test_meta_query_compare_not_exists_with_another_condition_relati
 
 	/**
 	 * @ticket 64696
+	 *
+	 * @dataProvider data_jit_meta_query_invalidation
 	 */
 	public function test_jit_meta_query_invalidation_adding_meta() {
 		$post_id = self::factory()->post->create();
@@ -785,11 +787,13 @@ public function test_jit_meta_query_invalidation_adding_meta() {
 
 	/**
 	 * @ticket 64696
+	 *
+	 * @dataProvider data_jit_meta_query_invalidation
 	 */
 	public function test_jit_meta_query_invalidation_updating_meta() {
 		$post_id = self::factory()->post->create();
 		wp_cache_set_posts_last_changed();
-		add_post_meta( $post_id, 'foo', 'bar' );
+		add_post_meta( $post_id, 'foo', 'baz' );
 
 		// Query posts by meta data.
 		$query = new WP_Query(
@@ -798,7 +802,7 @@ public function test_jit_meta_query_invalidation_updating_meta() {
 				'meta_query' => array(
 					array(
 						'key'   => 'foo',
-						'value' => 'baz',
+						'value' => 'bar',
 					),
 				),
 			)
@@ -807,7 +811,7 @@ public function test_jit_meta_query_invalidation_updating_meta() {
 		$posts_last_changed_initial = wp_cache_get_last_changed( 'posts' );
 
 		// Update post meta.
-		update_post_meta( $post_id, 'foo', 'baz' );
+		update_post_meta( $post_id, 'foo', 'bar' );
 
 		// Confirm last changed has not updated.
 		$this->assertSame( $posts_last_changed_initial, wp_cache_get_last_changed( 'posts' ), 'Updating meta data should not invalidate post query cache.' );
@@ -819,7 +823,7 @@ public function test_jit_meta_query_invalidation_updating_meta() {
 				'meta_query' => array(
 					array(
 						'key'   => 'foo',
-						'value' => 'baz',
+						'value' => 'bar',
 					),
 				),
 			)
@@ -833,6 +837,8 @@ public function test_jit_meta_query_invalidation_updating_meta() {
 
 	/**
 	 * @ticket 64696
+	 *
+	 * @dataProvider data_jit_meta_query_invalidation
 	 */
 	public function test_jit_meta_query_invalidation_deleting_meta() {
 		$post_id = self::factory()->post->create();
@@ -878,6 +884,51 @@ public function test_jit_meta_query_invalidation_deleting_meta() {
 		$this->assertNotContains( $post_id, $query->posts, 'Queried post should not be in results after meta data deleted.' );
 	}
 
+	/**
+	 * Data provider for:
+	 * - test_jit_meta_query_invalidation_adding_meta
+	 * - test_jit_meta_query_invalidation_updating_meta
+	 * - test_jit_meta_query_invalidation_deleting_meta
+	 *
+	 * @return array<string, array> Data provider.
+	 */
+	public function data_jit_meta_query_invalidation() {
+		return array(
+			'meta_query key only'               => array(
+				'meta_query' => array(
+					array(
+						'key' => 'foo',
+					),
+				),
+			),
+			'meta_query value only'             => array(
+				'meta_query' => array(
+					array(
+						'value' => 'bar',
+					),
+				),
+			),
+			'meta_query key and value'          => array(
+				'meta_query' => array(
+					array(
+						'key'   => 'foo',
+						'value' => 'bar',
+					),
+				),
+			),
+			'meta_key top level only'           => array(
+				'meta_key' => 'foo',
+			),
+			'meta_value top level only'         => array(
+				'meta_value' => 'bar',
+			),
+			'meta_key and meta_value top level' => array(
+				'meta_key'   => 'foo',
+				'meta_value' => 'bar',
+			),
+		);
+	}
+
 	/**
 	 * @ticket 24093
 	 */