[feat] #178 select-album 모듈 구현 및 upload-album 전환#185
Merged
Conversation
- feature:select-album (api, impl) 모듈 신규 생성 - app 모듈 및 settings.gradle.kts에 신규 모듈 의존성 추가
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough이 PR은 기존의 직접 사진 업로드-앨범 플로우를 새로운 통합 SelectAlbum 기능으로 대체합니다. UploadAlbum 기능을 완전히 제거하고 QR 코드 및 갤러리 사진 업로드 모두를 처리하는 새로운 SelectAlbum 기능 모듈을 도입합니다. Changes
Sequence DiagramsequenceDiagram
actor User
participant Main as Main Screen
participant MainVM as MainViewModel
participant SelectAlbumNav as SelectAlbum Navigation
participant SelectAlbumScreen as SelectAlbum Screen
participant SelectAlbumVM as SelectAlbumViewModel
participant PhotoRepo as Photo/Folder Repo
participant UploadUseCase as Upload UseCase
User->>Main: 갤러리/QR로 업로드 시작
Main->>MainVM: ClickUploadWithAlbum Intent
MainVM->>MainVM: SelectAlbumAction 생성
MainVM->>MainVM: NavigateToSelectAlbum SideEffect 방출
Main->>SelectAlbumNav: navigateToSelectAlbum(action) 호출
SelectAlbumNav->>SelectAlbumScreen: 라우트 생성
SelectAlbumScreen->>SelectAlbumVM: 초기화
SelectAlbumVM->>PhotoRepo: 즐겨찾기/앨범 목록 로드
PhotoRepo-->>SelectAlbumVM: 앨범 데이터 반환
SelectAlbumVM->>SelectAlbumVM: State 업데이트
SelectAlbumVM-->>SelectAlbumScreen: uiState emit
SelectAlbumScreen->>User: 앨범 목록 표시
User->>SelectAlbumScreen: 앨범 선택 및 확인
SelectAlbumScreen->>SelectAlbumVM: ClickConfirmButton Intent
SelectAlbumVM->>UploadUseCase: uploadSinglePhotoUseCase/uploadMultiplePhotoUseCase 호출
UploadUseCase-->>SelectAlbumVM: 업로드 성공/실패
SelectAlbumVM->>SelectAlbumVM: SendUploadResult SideEffect 방출
SelectAlbumVM-->>SelectAlbumScreen: SideEffect 처리
SelectAlbumScreen->>Main: navigateToAlbumDetail/navigateBack
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt (1)
125-148: 앨범 생성 중 로딩 표시 부재
handleAddAlbum에서 네트워크 요청 중 로딩 상태를 설정하지 않습니다. 사용자가 "추가하기" 버튼을 여러 번 클릭하면 중복 요청이 발생할 수 있습니다.🔧 로딩 상태 추가 제안
private fun handleAddAlbum( albumName: String, reduce: (SelectAlbumState.() -> SelectAlbumState) -> Unit, postSideEffect: (SelectAlbumSideEffect) -> Unit, ) { viewModelScope.launch { + reduce { copy(isLoading = true) } folderRepository.createFolder(name = albumName) .onSuccess { fetchFolders(reduce) reduce { copy( + isLoading = false, isShowAddAlbumBottomSheet = false, albumNameTextState = TextFieldState(), ) } postSideEffect(SelectAlbumSideEffect.ShowToastMessage("새로운 앨범을 추가했어요")) } .onFailure { e -> Timber.e(e) - reduce { copy(isShowAddAlbumBottomSheet = false, albumNameTextState = TextFieldState()) } + reduce { copy(isLoading = false, isShowAddAlbumBottomSheet = false, albumNameTextState = TextFieldState()) } postSideEffect(SelectAlbumSideEffect.ShowToastMessage("앨범 추가에 실패했어요")) } } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt` around lines 125 - 148, The add-album flow in handleAddAlbum does not set a loading flag so duplicate taps can trigger multiple requests; before launching folderRepository.createFolder inside viewModelScope.launch, call reduce to set a new SelectAlbumState flag (e.g., isAddingAlbum or isLoadingAlbum = true) and disable the add button in the UI based on that flag, then after onSuccess and onFailure ensure you reset that flag to false (alongside the existing isShowAddAlbumBottomSheet and albumNameTextState updates); optionally, guard at the top of handleAddAlbum by checking the state flag and returning early if already loading to fully prevent concurrent requests.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@feature/select-album/api/src/main/java/com/neki/android/feature/select_album/api/SelectAlbumNavKey.kt`:
- Line 7: Remove the unnecessary consecutive blank line in SelectAlbumNavKey.kt
that triggers Detekt's NoConsecutiveBlankLines rule (the extra empty line around
line 7); open the file containing the SelectAlbumNavKey declaration and delete
the extra blank line so there is only a single empty line between
sections/statements, then run Detekt/CI to confirm the warning is resolved.
In
`@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt`:
- Around line 69-73: SelectAlbumViewModel currently passes the raw album name
from the intent handler to handleAddAlbum without defensive
trimming/empty-checking; update the ClickAddAlbumConfirmButton handling in
SelectAlbumViewModel so that before calling handleAddAlbum you call .trim() on
state.albumNameTextState.text and skip/return early (or do not call
handleAddAlbum) if the trimmed string is empty, matching the pattern used in
ArchiveMainViewModel.handleAddAlbum; ensure reduce and postSideEffect are
preserved when calling handleAddAlbum.
---
Nitpick comments:
In
`@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt`:
- Around line 125-148: The add-album flow in handleAddAlbum does not set a
loading flag so duplicate taps can trigger multiple requests; before launching
folderRepository.createFolder inside viewModelScope.launch, call reduce to set a
new SelectAlbumState flag (e.g., isAddingAlbum or isLoadingAlbum = true) and
disable the add button in the UI based on that flag, then after onSuccess and
onFailure ensure you reset that flag to false (alongside the existing
isShowAddAlbumBottomSheet and albumNameTextState updates); optionally, guard at
the top of handleAddAlbum by checking the state flag and returning early if
already loading to fully prevent concurrent requests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e6db1ab7-926d-427f-a80a-f2f6d956babe
📒 Files selected for processing (21)
app/build.gradle.ktsapp/src/main/java/com/neki/android/app/MainActivity.ktapp/src/main/java/com/neki/android/app/main/MainContract.ktapp/src/main/java/com/neki/android/app/main/MainScreen.ktapp/src/main/java/com/neki/android/app/main/MainViewModel.ktfeature/photo-upload/api/src/main/java/com/neki/android/feature/photo_upload/api/PhotoUploadNavKey.ktfeature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/album/UploadAlbumContract.ktfeature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/album/UploadAlbumScreen.ktfeature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/album/UploadAlbumViewModel.ktfeature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/album/component/UploadAlbumTopBar.ktfeature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/di/PhotoUploadEntryProvider.ktfeature/select-album/api/build.gradle.ktsfeature/select-album/api/src/main/java/com/neki/android/feature/select_album/api/SelectAlbumNavKey.ktfeature/select-album/api/src/main/java/com/neki/android/feature/select_album/api/SelectAlbumResult.ktfeature/select-album/impl/build.gradle.ktsfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumContract.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumTopBar.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/navigation/SelectAlbumEntryProvider.ktsettings.gradle.kts
💤 Files with no reviewable changes (6)
- feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/di/PhotoUploadEntryProvider.kt
- feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/album/component/UploadAlbumTopBar.kt
- feature/photo-upload/api/src/main/java/com/neki/android/feature/photo_upload/api/PhotoUploadNavKey.kt
- feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/album/UploadAlbumContract.kt
- feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/album/UploadAlbumScreen.kt
- feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/album/UploadAlbumViewModel.kt
Ojongseok
reviewed
Apr 9, 2026
There was a problem hiding this comment.
♻️ Duplicate comments (1)
feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt (1)
65-69:⚠️ Potential issue | 🟡 Minor공백 앨범명이 생성 요청으로 전달될 수 있습니다.
Line 65-67에서 입력값을 그대로 넘겨
" "같은 값이 요청으로 전달될 수 있습니다. ViewModel에서trim()후 빈 값이면 조기 반환해 주세요. (이 이슈는 이전 리뷰에서도 이미 지적된 항목입니다.)제안 수정안
- SelectAlbumIntent.ClickAddAlbumConfirmButton -> handleAddAlbum( - albumName = state.albumNameTextState.text.toString(), - reduce = reduce, - postSideEffect = postSideEffect, - ) + SelectAlbumIntent.ClickAddAlbumConfirmButton -> { + val trimmedAlbumName = state.albumNameTextState.text.toString().trim() + if (trimmedAlbumName.isEmpty()) return + handleAddAlbum( + albumName = trimmedAlbumName, + reduce = reduce, + postSideEffect = postSideEffect, + ) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt` around lines 65 - 69, When handling SelectAlbumIntent.ClickAddAlbumConfirmButton, sanitize the input before calling handleAddAlbum: retrieve state.albumNameTextState.text, call trim() and if the resulting string is empty return early (do not call handleAddAlbum or post side effects); otherwise pass the trimmed string as albumName into handleAddAlbum so no whitespace-only names are sent to the request.
🧹 Nitpick comments (1)
feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt (1)
130-141: 성공/실패 분기의 바텀시트 초기화 로직이 중복됩니다.Line 130-135와 Line 140에서 동일 상태 초기화가 반복됩니다. 헬퍼로 추출하면 추후 상태 변경 시 누락 위험을 줄일 수 있습니다.
리팩터링 예시
+ private fun resetAddAlbumSheetState( + reduce: (SelectAlbumState.() -> SelectAlbumState) -> Unit, + ) { + reduce { + copy( + isShowAddAlbumBottomSheet = false, + albumNameTextState = TextFieldState(), + ) + } + } + private fun handleAddAlbum( albumName: String, reduce: (SelectAlbumState.() -> SelectAlbumState) -> Unit, postSideEffect: (SelectAlbumSideEffect) -> Unit, ) { viewModelScope.launch { folderRepository.createFolder(name = albumName) .onSuccess { fetchFolders(reduce) - reduce { - copy( - isShowAddAlbumBottomSheet = false, - albumNameTextState = TextFieldState(), - ) - } + resetAddAlbumSheetState(reduce) postSideEffect(SelectAlbumSideEffect.ShowToastMessage("새로운 앨범을 추가했어요")) } .onFailure { e -> Timber.e(e) - reduce { copy(isShowAddAlbumBottomSheet = false, albumNameTextState = TextFieldState()) } + resetAddAlbumSheetState(reduce) postSideEffect(SelectAlbumSideEffect.ShowToastMessage("앨범 추가에 실패했어요")) } } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt` around lines 130 - 141, The reduce logic that resets isShowAddAlbumBottomSheet and albumNameTextState is duplicated in both the success and failure branches of the add-album flow; extract a single helper (e.g., a private method resetAddAlbumUiState or an inline function resetAddAlbumState) and call it from both the success path (after reduce { ... } currently) and the onFailure path before posting side effects, updating uses of reduce, SelectAlbumSideEffect, albumNameTextState, and isShowAddAlbumBottomSheet so the UI-reset behavior is centralized and only maintained in one place.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In
`@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt`:
- Around line 65-69: When handling SelectAlbumIntent.ClickAddAlbumConfirmButton,
sanitize the input before calling handleAddAlbum: retrieve
state.albumNameTextState.text, call trim() and if the resulting string is empty
return early (do not call handleAddAlbum or post side effects); otherwise pass
the trimmed string as albumName into handleAddAlbum so no whitespace-only names
are sent to the request.
---
Nitpick comments:
In
`@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt`:
- Around line 130-141: The reduce logic that resets isShowAddAlbumBottomSheet
and albumNameTextState is duplicated in both the success and failure branches of
the add-album flow; extract a single helper (e.g., a private method
resetAddAlbumUiState or an inline function resetAddAlbumState) and call it from
both the success path (after reduce { ... } currently) and the onFailure path
before posting side effects, updating uses of reduce, SelectAlbumSideEffect,
albumNameTextState, and isShowAddAlbumBottomSheet so the UI-reset behavior is
centralized and only maintained in one place.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 90a557b9-6173-48e5-8338-ed285d72aa0a
📒 Files selected for processing (1)
feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.kt (1)
124-131: 앨범명 중복 검사에서favoriteAlbum누락 가능성
existingAlbumNames가uiState.albums만 포함하고uiState.favoriteAlbum.title은 포함하지 않습니다. 즐겨찾기 앨범명과 동일한 이름으로 새 앨범을 생성하려는 경우 중복 검사가 작동하지 않을 수 있습니다. 서버에서 중복 검사를 수행한다면 문제없지만, 클라이언트 UX 측면에서 검토가 필요합니다.수정 제안
- val existingAlbumNames = remember(uiState.albums) { uiState.albums.map { it.title } } + val existingAlbumNames = remember(uiState.albums, uiState.favoriteAlbum) { + uiState.albums.map { it.title } + uiState.favoriteAlbum.title + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.kt` around lines 124 - 131, existingAlbumNames is built only from uiState.albums so the favorite album title (uiState.favoriteAlbum.title) can be omitted and allow a duplicate name; update the logic in SelectAlbumScreen to include the favorite title when computing existingAlbumNames (e.g., build the list from uiState.albums plus uiState.favoriteAlbum?.title if non-null) and adjust the remember dependencies to include uiState.favoriteAlbum (or its title) so errorMessage's derivedStateOf correctly re-evaluates; ensure null-safe handling of uiState.favoriteAlbum before adding it to the list.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.kt`:
- Around line 101-103: SelectAlbumScreen currently renders
FavoriteAlbumRowComponent without wiring its onClick; update the item block that
uses FavoriteAlbumRowComponent (with uiState.favoriteAlbum) to pass onClick = {
onIntent(AllAlbumIntent.ClickFavoriteAlbum) } so the favorite-album selection
flow matches AllAlbumScreen; ensure you reference the existing onIntent handler
and AllAlbumIntent.ClickFavoriteAlbum when adding the onClick param.
---
Nitpick comments:
In
`@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.kt`:
- Around line 124-131: existingAlbumNames is built only from uiState.albums so
the favorite album title (uiState.favoriteAlbum.title) can be omitted and allow
a duplicate name; update the logic in SelectAlbumScreen to include the favorite
title when computing existingAlbumNames (e.g., build the list from
uiState.albums plus uiState.favoriteAlbum?.title if non-null) and adjust the
remember dependencies to include uiState.favoriteAlbum (or its title) so
errorMessage's derivedStateOf correctly re-evaluates; ensure null-safe handling
of uiState.favoriteAlbum before adding it to the list.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f34af0bb-1f34-4318-a2f4-dbc95a31106f
📒 Files selected for processing (11)
app/src/main/java/com/neki/android/app/MainActivity.ktapp/src/main/java/com/neki/android/app/main/MainContract.ktapp/src/main/java/com/neki/android/app/main/MainScreen.ktapp/src/main/java/com/neki/android/app/main/MainViewModel.ktfeature/select-album/api/src/main/java/com/neki/android/feature/select_album/api/SelectAlbumAction.ktfeature/select-album/api/src/main/java/com/neki/android/feature/select_album/api/SelectAlbumNavKey.ktfeature/select-album/impl/build.gradle.ktsfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumContract.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/navigation/SelectAlbumEntryProvider.kt
✅ Files skipped from review due to trivial changes (1)
- feature/select-album/api/src/main/java/com/neki/android/feature/select_album/api/SelectAlbumAction.kt
🚧 Files skipped from review as they are similar to previous changes (5)
- app/src/main/java/com/neki/android/app/MainActivity.kt
- feature/select-album/impl/build.gradle.kts
- app/src/main/java/com/neki/android/app/main/MainContract.kt
- app/src/main/java/com/neki/android/app/main/MainScreen.kt
- app/src/main/java/com/neki/android/app/main/MainViewModel.kt
Ojongseok
reviewed
Apr 12, 2026
Member
There was a problem hiding this comment.
해당 컴포넌트는 component 디렉토리 만들어서 하위에 위치시키죠 !
Comment on lines
+11
to
+12
| val title: String = "모든 앨범", | ||
| val multiSelect: Boolean = true, |
Member
There was a problem hiding this comment.
navigateToSelectAlbum()에서 title과 multiSelect의 초기값이 동일하게 지정되어 넘어오는데 SelectAlbum 내부에서는 초기값 정의하지 않아도 되지 않을까요?
Contributor
Author
There was a problem hiding this comment.
기존 코드에 영향이 있을까 해서 했는데 중첩이었군요, 087e979 반영했습니다!
Comment on lines
+77
to
+79
| uploadSingleImage(state.scannedImageUrl, reduce = reduce, postSideEffect = postSideEffect) | ||
| } else { | ||
| postSideEffect(MainSideEffect.NavigateToUploadAlbumWithGallery(state.selectedUris.map { it.toString() })) | ||
| uploadMultipleImages(state.selectedUris, reduce = reduce, postSideEffect = postSideEffect) |
Member
There was a problem hiding this comment.
일관되게 첫번째 파라미터명 명시해주시면 좋을 것 같습니다
| SelectAlbumIntent.EnterSelectAlbumScreen -> fetchInitialData(reduce) | ||
| SelectAlbumIntent.ClickBackIcon -> postSideEffect(SelectAlbumSideEffect.NavigateBack) | ||
| SelectAlbumIntent.ClickConfirmButton -> { | ||
| if (state.isUploading) return |
Member
There was a problem hiding this comment.
방어적으로 작성하기 위함인건 이해했으나 (isLoading || isUploading) 일 때 LoadingDialog()가 노출되어 사실 n장 업로드 버튼을 선택할 수 없는데 해당 부분에서만 유독 방어적으로 작성할 필요가 있을까요.?.?
UIState에 isConfirmEnabled 플래그를 통해 한 번 방어하고 있기도 하구요!
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt (1)
77-81:⚠️ Potential issue | 🟡 Minor앨범명 입력은 ViewModel에서
trim/빈값 방어가 필요합니다Line 77-81에서 공백만 있는 입력이 그대로 전달됩니다. UI 검증과 별개로 ViewModel 방어 로직을 두는 편이 안전합니다.
수정 제안
- SelectAlbumIntent.ClickAddAlbumConfirmButton -> handleAddAlbum( - albumName = state.albumNameTextState.text.toString(), - reduce = reduce, - postSideEffect = postSideEffect, - ) + SelectAlbumIntent.ClickAddAlbumConfirmButton -> { + val albumName = state.albumNameTextState.text.toString().trim() + if (albumName.isBlank()) return + handleAddAlbum( + albumName = albumName, + reduce = reduce, + postSideEffect = postSideEffect, + ) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt` around lines 77 - 81, The ClickAddAlbumConfirmButton branch passes raw input to handleAddAlbum allowing whitespace-only names; update the SelectAlbumIntent.ClickAddAlbumConfirmButton handling to trim the input (use state.albumNameTextState.text.toString().trim()) and guard against empty strings before calling handleAddAlbum — if the trimmed name is empty, short-circuit (e.g., postSideEffect or reduce an error/validation state) instead of invoking handleAddAlbum; this ensures handleAddAlbum receives a non-empty, trimmed albumName.feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.kt (1)
103-105:⚠️ Potential issue | 🟡 Minor즐겨찾기 앨범 행에 선택 액션 연결이 빠져 있습니다
Line 104는 렌더링만 하고 있어 즐겨찾기 앨범을 선택 대상으로 사용할 수 없습니다.
수정 제안
item { - FavoriteAlbumRowComponent(album = uiState.favoriteAlbum) + FavoriteAlbumRowComponent( + album = uiState.favoriteAlbum, + onClick = { onIntent(SelectAlbumIntent.ClickAlbumItem(uiState.favoriteAlbum)) }, + ) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.kt` around lines 103 - 105, The Favorite album row is rendered but has no selection handler, so make FavoriteAlbumRowComponent in SelectAlbumScreen accept and receive a click/select callback and forward the selection: add an onClick/onSelect lambda parameter to FavoriteAlbumRowComponent and, where it is called in SelectAlbumScreen (passing uiState.favoriteAlbum), pass a lambda that invokes the existing selection handler (e.g., call viewModel.selectAlbum(uiState.favoriteAlbum) or the screen's onAlbumSelected callback) so tapping the row selects the favorite album.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt`:
- Around line 68-71: The ClickConfirmButton handler and performUpload path can
re-enter and may leave isUploading stuck if a UseCase throws; add a guard at the
start of the ClickConfirmButton branch to return early when state.isUploading is
true, then ensure performUpload (and any other upload paths around the 90-116
block) sets isUploading = true before performing work and always resets it to
false in a finally block (or use runCatching/onFailure) so exceptions don't
leave isUploading set; update references: SelectAlbumIntent.ClickConfirmButton,
state.selectedAlbums, performUpload, reduce, postSideEffect, and the isUploading
state to implement the guard and the try/finally reset.
- Around line 69-70: The code currently uploads only the first selected album
(val album = state.selectedAlbums.firstOrNull()) while the UI allows multiple
selection; update SelectAlbumViewModel to handle all selected albums
consistently by iterating state.selectedAlbums (or guard to enforce
single-selection at the state/UI level). If choosing iteration, replace the
single-call to performUpload with a loop over state.selectedAlbums calling
performUpload(album, reduce, postSideEffect) for each non-null album; if
choosing single-selection, change the selection model so state.selectedAlbums
contains at most one item and keep the existing performUpload call. Ensure
references to state.selectedAlbums and performUpload remain consistent.
---
Duplicate comments:
In
`@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.kt`:
- Around line 103-105: The Favorite album row is rendered but has no selection
handler, so make FavoriteAlbumRowComponent in SelectAlbumScreen accept and
receive a click/select callback and forward the selection: add an
onClick/onSelect lambda parameter to FavoriteAlbumRowComponent and, where it is
called in SelectAlbumScreen (passing uiState.favoriteAlbum), pass a lambda that
invokes the existing selection handler (e.g., call
viewModel.selectAlbum(uiState.favoriteAlbum) or the screen's onAlbumSelected
callback) so tapping the row selects the favorite album.
In
`@feature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.kt`:
- Around line 77-81: The ClickAddAlbumConfirmButton branch passes raw input to
handleAddAlbum allowing whitespace-only names; update the
SelectAlbumIntent.ClickAddAlbumConfirmButton handling to trim the input (use
state.albumNameTextState.text.toString().trim()) and guard against empty strings
before calling handleAddAlbum — if the trimmed name is empty, short-circuit
(e.g., postSideEffect or reduce an error/validation state) instead of invoking
handleAddAlbum; this ensures handleAddAlbum receives a non-empty, trimmed
albumName.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2d1b060d-56e7-45bd-99f6-3a9573d9a79c
📒 Files selected for processing (5)
app/src/main/java/com/neki/android/app/main/MainViewModel.ktfeature/select-album/api/src/main/java/com/neki/android/feature/select_album/api/SelectAlbumNavKey.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumScreen.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/SelectAlbumViewModel.ktfeature/select-album/impl/src/main/java/com/neki/android/feature/select_album/impl/component/SelectAlbumTopBar.kt
✅ Files skipped from review due to trivial changes (1)
- feature/select-album/api/src/main/java/com/neki/android/feature/select_album/api/SelectAlbumNavKey.kt
🚧 Files skipped from review as they are similar to previous changes (1)
- app/src/main/java/com/neki/android/app/main/MainViewModel.kt
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 설명
feature/select-album모듈(api/impl) 생성 및 의존성 설정upload-album제거 후select-album으로 전환SelectAlbumActionsealed interface 도입: 네비게이션 시 업로드 유형(QR/갤러리) 전달🧪 테스트 내역 (선택)
📸 스크린샷 또는 시연 영상 (선택)
Screen_recording_20260410_015713.mp4
💬 추가 설명 or 리뷰 포인트 (선택)
SelectAlbumAction을 NavKey에 담아 전달:UploadFromQR(imageUrl)/UploadFromGallery(imageUriStrings)AlbumDetailResult전송 → Archive 자동 갱신 (별도 ResultBus 이벤트 불필요)Summary by CodeRabbit
릴리스 노트