Skip to content

Wrong remainder?#80

Merged
Zinoex merged 2 commits intoZinoex:mainfrom
adrienbanse:main
Mar 11, 2025
Merged

Wrong remainder?#80
Zinoex merged 2 commits intoZinoex:mainfrom
adrienbanse:main

Conversation

@adrienbanse
Copy link
Contributor

Many thanks @Zinoex for the great package and doc!

Only 80% sure, but the remainder of the O-maximization algorithm should be 1 - sum(p) right?

Also, something that puzzled me is that the ordering is first in ascending order in the doc (for O-minimization), and then in descending order (for O-maximization). But I didn't change anything yet.

@Zinoex
Copy link
Owner

Zinoex commented Mar 11, 2025

You are absolutely right about the remainder in O-maximization! Thanks for spotting that.

About the ascending then descending question, I think the confusion is rather about the naming O-maximization. It means order maximization, thus when we minimize the expected value of V, we maximize the mass in ascending order of V (assign most probability to the states with the least value in V).

Does that help your understanding? Please do feel free to add a comment in the docs to explain this peculiarity.

@adrienbanse
Copy link
Contributor Author

Okay it's clearer!

In my case I wanted to maximize the sum, so I take the inverse order in the algorithm. I thought it was O-maximization, but it is in fact O-minimization.

Thanks!

@Zinoex Zinoex merged commit fdad34d into Zinoex:main Mar 11, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants