skipValidationAndResolution condition in decoratormanager

[DianaLease]

Bug Report 🐛

Copilot surfaced this issue in #1156, although the issue was pre-existing and not related to the PR changes./
packages/concerto-core/lib/decoratormanager.js:395

The guard for skipValidationAndResolution has a logic error: !options?.disableMetamodelValidation === false evaluates to true when disableMetamodelValidation is true, so it throws in a configuration that should be allowed. This should check whether disableMetamodelValidation is explicitly set to false (similar to the disableMetamodelResolution check).
current code:

        if (options?.skipValidationAndResolution) {
            if (options?.disableMetamodelResolution === false || !options?.disableMetamodelValidation === false) {
                throw new Error('skipValidationAndResolution cannot be used with disableMetamodelResolution or disableMetamodelValidation options as false');
            }

Expected Behavior

Current Behavior

Possible Solution

- if (options?.disableMetamodelResolution === false || !options?.disableMetamodelValidation === false) {
+ if (options?.disableMetamodelResolution === false || options?.disableMetamodelValidation === false) {

Steps to Reproduce

Context (Environment)

Desktop

• OS: [e.g. macOS]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 0.22.15]

Detailed Description

Possible Implementation