Inconsistent ast types in introspect

[ekarademir]

Bug Report 🐛

Types of ast fields are sometimes string, sometimes any. Instead maybe they should conform to the generated types.

Expected Behavior

If I use ast property of a ClassDeclaration, it should have the type IDeclaration instead of string.

Current Behavior

If I use ast property of a ClassDeclaration, it has the type string instead of IDeclaration.

Possible Solution

Steps to Reproduce

1. Create a ModelFile that has declarations
2. Obtain one of the declarations with for instance modelFile.getAllDeclarations().at(0)
3. Now access the ast property of that declaration and check type with typeof declaration (no pun intended)
4. typeof myDeclaration is object but TypeScript assumes that it's string, because of the type definition file.

Context (Environment)

Desktop

• OS: macOS Ventura
• Browser: NodeJS
• Version: 18.17.1

Detailed Description

Possible Implementation

[subhajit20]

hey @ekarademir How can I get access of concerto-type package? I tried to import that a couple of times but the module not found an error occurring

[subhajit20]

I am able to reproduce the type bug.
Should I change the last inside the type file of decorated file itself or should I change anything else? Just need some suggestions

[TC5022]

@ekarademir @sanketshevkar the PR opened by @subhajit20 has been closed. If he is not working on this issue can it be assigned to me?

[Aditya-twd]

@ekarademir @sanketshevkar

This inconsistency between the runtime ast shape and its TypeScript types (sometimes string, sometimes any) makes introspect hard to use in a type-safe way, so aligning ast to the generated AST interfaces across all declarations would greatly improve DX, and I'd be happy to help with a PR in that direction.