From b129d9156f45005e28960fedc83cf0c8e3bb1984 Mon Sep 17 00:00:00 2001 From: Denis Buzdalov Date: Tue, 24 Jun 2014 12:57:44 +0400 Subject: [PATCH 1/3] The ORM config class' constructor was made protected. This makes the user able to create ORM config with the custom SqlWriterStrategy which seems to be useful. --- jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java b/jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java index 436ad30..7328701 100644 --- a/jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java +++ b/jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java @@ -25,7 +25,7 @@ public class OrmConfig { private final SqlObjectConfig sqlObjectConfig; private final SqlWriterStrategy sqlWriterStrategy; - private OrmConfig(SqlExecutor sqlExecutor, SqlObjectConfig sqlObjectConfig, SqlWriterStrategy sqlWriterStrategy) { + protected OrmConfig(SqlExecutor sqlExecutor, SqlObjectConfig sqlObjectConfig, SqlWriterStrategy sqlWriterStrategy) { super(); this.sqlExecutor = sqlExecutor; this.sqlObjectConfig = sqlObjectConfig; From 9207122fe28c699f59b2d57d27dbf54af7e0cee4 Mon Sep 17 00:00:00 2001 From: Denis Buzdalov Date: Tue, 24 Jun 2014 13:07:52 +0400 Subject: [PATCH 2/3] Well, it seems it's better to have event 'public' ORM config constructor. --- jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java b/jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java index 7328701..01147b1 100644 --- a/jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java +++ b/jirm-orm/src/main/java/co/jirm/orm/OrmConfig.java @@ -25,7 +25,7 @@ public class OrmConfig { private final SqlObjectConfig sqlObjectConfig; private final SqlWriterStrategy sqlWriterStrategy; - protected OrmConfig(SqlExecutor sqlExecutor, SqlObjectConfig sqlObjectConfig, SqlWriterStrategy sqlWriterStrategy) { + public OrmConfig(SqlExecutor sqlExecutor, SqlObjectConfig sqlObjectConfig, SqlWriterStrategy sqlWriterStrategy) { super(); this.sqlExecutor = sqlExecutor; this.sqlObjectConfig = sqlObjectConfig; From a807fa97685af68d0d98a9995776b43beef327b3 Mon Sep 17 00:00:00 2001 From: Denis Buzdalov Date: Tue, 24 Jun 2014 13:21:29 +0400 Subject: [PATCH 3/3] A constructor with parameters of the factory method was added to the sql writer strategy class. --- .../src/main/java/co/jirm/orm/writer/SqlWriterStrategy.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/jirm-orm/src/main/java/co/jirm/orm/writer/SqlWriterStrategy.java b/jirm-orm/src/main/java/co/jirm/orm/writer/SqlWriterStrategy.java index 30b2c15..4cdb101 100644 --- a/jirm-orm/src/main/java/co/jirm/orm/writer/SqlWriterStrategy.java +++ b/jirm-orm/src/main/java/co/jirm/orm/writer/SqlWriterStrategy.java @@ -47,8 +47,12 @@ protected SqlWriterStrategy(Joiner commaJoiner, String clauseSpaceSeparator) { this.clauseSpaceSeparator = clauseSpaceSeparator; } + protected SqlWriterStrategy(String sep) { + this(Joiner.on("," + sep), sep); + } + public static SqlWriterStrategy newInstance(String sep) { - return new SqlWriterStrategy(Joiner.on("," + sep),sep); + return new SqlWriterStrategy(sep); } public StringBuilder insertStatement(StringBuilder qb, final SqlObjectDefinition definition, Map m) {