Merge pull request #135 from ai-agent-assembly/v0.0.1/AAASM-3062/fix/sonar_s5443_runtime_interceptor

[AAASM-3062] 🔒 (python-sdk): Fix S5443 publicly-writable-dir in runtime_interceptor.py

Author: Chisanan232

agent_assembly/core/runtime_interceptor.py

@@ -39,11 +39,25 @@ def _resolve_runtime_socket_path(agent_id: str) -> str:
     Mirrors ``aa-ffi-python``'s ``AssemblyConfig::resolve_socket_path``: the
     ``AA_RUNTIME_SOCKET`` environment variable takes precedence, otherwise the
     per-agent default ``/tmp/aa-runtime-<agent_id>.sock`` is used.
+
+    Note: the ``/tmp/aa-runtime-<agent_id>.sock`` literal mirrors the canonical
+    path baked into ``aa-sdk-client::AssemblyConfig::resolve_socket_path`` on the
+    Rust side. This path is the SDK↔runtime IPC contract: ``aa-runtime`` binds
+    the UDS server here and every SDK (Python, Node, Go) connects here. The SDK
+    only *connects* to a path the runtime created; it never writes the socket
+    itself. Operators who need to relocate the socket (e.g. multi-tenant hosts)
+    set ``AA_RUNTIME_SOCKET`` to override. Replacing the literal with
+    ``tempfile.gettempdir()`` would break interop on platforms where it does not
+    resolve to ``/tmp`` (notably macOS dev hosts).
     """
     env_path = os.environ.get(ENV_RUNTIME_SOCKET)
     if env_path:
         return env_path
-    return f"/tmp/aa-runtime-{agent_id}.sock"
+    # IPC contract path (see docstring above). The SDK is a *client* of a
+    # socket the runtime creates; this code never writes to /tmp itself.
+    # SonarCloud python:S5443 is suppressed project-wide for this file via
+    # sonar-project.properties; ruff S108 is suppressed inline below.
+    return f"/tmp/aa-runtime-{agent_id}.sock"  # noqa: S108
 
 
 def _extract_tool_name(serialized: Any, kwargs: dict[str, Any]) -> str | None:

sonar-project.properties

@@ -27,5 +27,16 @@ sonar.coverage.exclusions=agent_assembly/types.py
 # Ignore some test files
 # sonar.test.exclusions=tests/helpers/**
 
+# Rule-specific exclusions (AAASM-3062). The runtime_interceptor's
+# `/tmp/aa-runtime-<agent_id>.sock` literal is the SDK<->runtime IPC contract
+# path (mirrored on the Rust side by aa-sdk-client::AssemblyConfig
+# ::resolve_socket_path). The SDK only *connects* to a socket the runtime
+# creates; it never writes to /tmp itself. Operators relocate via
+# AA_RUNTIME_SOCKET. Inline NOSONAR does not suppress python:S5443 on
+# vulnerability rules for this analyzer, so the exclusion is declared here.
+sonar.issue.ignore.multicriteria=e1
+sonar.issue.ignore.multicriteria.e1.ruleKey=python:S5443
+sonar.issue.ignore.multicriteria.e1.resourceKey=**/runtime_interceptor.py
+
 # Encoding of the source code. Default is default system encoding
 sonar.sourceEncoding=UTF-8