gfx4snes: Wrong type for map in inc file

[frcs6]

Currently, gfx4snes export map with unsigned short, but it should be unsigned char (examples are like that).

// Exported by gfx4snes 
#ifndef grid_H_
#define grid_H_

#include <snes.h>

extern unsigned char grid_til,grid_tilend;

---extern unsigned short grid_map,grid_mapend;
+++extern unsigned char grid_map,grid_mapend;

extern unsigned char grid_pal,grid_palend;

#endif

The fix may be in incgener.c

---#define WRITEFILEMAP 			"extern unsigned short %s_map,%s_mapend;\n\n"
+++#define WRITEFILEMAP 			"extern unsigned char %s_map,%s_mapend;\n\n"

[alekmaul]

No, map attribute are coded with 16 bits, why do you want char ?

[frcs6]

In your example, you use char Mode1.c.

With unsigned short

With unsigned char

[frcs6]

gfx4snes command:

grid.pic: assets/grid.png
	@echo convert bitmap ... $(notdir $@)
	$(GFXCONV) -s 8 -o 16 -u 16 -e 0 -p -m -i $<

My code:

#include <snes.h>

// #include "assets/grid.inc"

extern unsigned char grid_til, grid_tilend;
extern unsigned char grid_map, grid_mapend;
extern unsigned char grid_pal, grid_palend;

// extern char grid_til, grid_tilend;
// extern char grid_pal, grid_palend;
// extern char grid_map, grid_mapend;

//---------------------------------------------------------------------------------
int main(void)
{
    // Copy tiles to VRAM
    bgInitTileSet(0, &grid_til, &grid_pal, 0, (&grid_tilend - &grid_til), (&grid_palend - &grid_pal), BG_16COLORS, 0x4000);

    // Copy grid_map to VRAM
    bgInitMapSet(0, &grid_map, (&grid_mapend - &grid_map), SC_32x32, 0x0000);

    // Now Put in 16 color mode and disable other BGs except 1st one
    setMode(BG_MODE1, 0);
    bgSetDisable(1);
    bgSetDisable(2);
    setScreenOn();

    // Wait for nothing :P
    while (1)
    {
        WaitForVBlank();
    }
    return 0;
}
``

[alekmaul]

yeah, it's because I use "pointer" to a value with can be a char or short. Tcc compiler is not very efficient with pointers.
One day, Il will need to adapt map to short instead of char.
So Mode1 example is no more working with gfx4snes "as is" ?

[frcs6]

Mode1 as is work, but the example don't use the .inc file generated, extern vars are directly in the .c file with the char type.

If I use the .inc file, it don´t work, because the .inc declare extern var in short type.

[frcs6]

I found a fix in my code that could be:

bgInitMapSet(0, (u8 *)&grid_map, ((u8 *)&grid_mapend - (u8 *)&grid_map), SC_32x32, 0x0000);

What do you think about it ?

Maybe I should just ignore .inc file and declare:

extern unsigned char grid_til, grid_tilend;
extern unsigned char grid_map, grid_mapend;
extern unsigned char grid_pal, grid_palend;

[alekmaul]

The goal is to use inc files generated by gfx4snes. I will fix examples. It is not a gfx4snes issue ;)