Skip to content

Maybe an important typo #4

@mkostich

Description

@mkostich

In Tw2.R, you have:

dist.cohen.d = function(dm, f){
  mean.diff = sqrt(WT.mean(dm, f))
  lev = levels(f)
  s1 = dist.sigma2(as.matrix(dm)[f==lev[1], f == lev[1]])
  s2 = dist.sigma2(as.matrix(dm)[f==lev[1], f == lev[1]])
  ns=table(f)
  mean.diff/sqrt(((ns[1]-1)*s1 + (ns[2]-1)*s2)/(sum(ns)-2))
}

I think maybe this should be:

dist.cohen.d = function(dm, f){
  mean.diff = sqrt(WT.mean(dm, f))
  lev = levels(f)
  s1 = dist.sigma2(as.matrix(dm)[f==lev[1], f == lev[1]])
  s2 = dist.sigma2(as.matrix(dm)[f==lev[2], f == lev[2]])           ## changed indices on this line
  ns=table(f)
  mean.diff/sqrt(((ns[1]-1)*s1 + (ns[2]-1)*s2)/(sum(ns)-2))
}

Is that right?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions