Fix or suppress Psalm 6 issues

Author: trowski

psalm.xml

@@ -14,12 +14,30 @@
     </projectFiles>
 
     <issueHandlers>
+        <PossiblyUnusedMethod>
+            <errorLevel type="suppress">
+                <directory name="src"/>
+            </errorLevel>
+        </PossiblyUnusedMethod>
+
+        <PossiblyUnusedReturnValue>
+            <errorLevel type="suppress">
+                <directory name="src"/>
+            </errorLevel>
+        </PossiblyUnusedReturnValue>
+
         <RiskyTruthyFalsyComparison>
             <errorLevel type="suppress">
                 <directory name="src"/>
             </errorLevel>
         </RiskyTruthyFalsyComparison>
 
+        <UnusedClass>
+            <errorLevel type="suppress">
+                <directory name="src"/>
+            </errorLevel>
+        </UnusedClass>
+
         <UnsupportedPropertyReferenceUsage>
             <errorLevel type="suppress">
                 <directory name="src"/>

src/Command/Boundary/ScoreBoundary.php

@@ -6,7 +6,7 @@ final class ScoreBoundary
 {
     public static function exclusive(float $value): self
     {
-        return new self('(' . $value);
+        return new self(sprintf('(%.5f', $value));
     }
 
     public static function inclusive(float $value): self

src/Command/RedisMap.php

@@ -157,7 +157,6 @@ public function scan(?string $pattern = null, ?int $count = null): \Traversable
                 $query[] = $count;
             }
 
-            /** @var list<string> $keys */
             [$cursor, $keys] = $this->client->execute('HSCAN', ...$query);
 
             $count = \count($keys);

src/Command/RedisSortedSet.php

@@ -218,7 +218,6 @@ public function scan(?string $pattern = null, ?int $count = null): \Traversable
                 $query[] = $count;
             }
 
-            /** @var list<string> $keys */
             [$cursor, $keys] = $this->client->execute('ZSCAN', ...$query);
 
             $count = \count($keys);

src/Connection/ReconnectingRedisLink.php

@@ -100,13 +100,12 @@ private function run(): void
                     $connection->unreference();
 
                     try {
-                        foreach ($queue as [$deferred, $command, $parameters]) {
+                        foreach ($queue as [, $command, $parameters]) {
                             $connection->reference();
                             $connection->send($command, ...$parameters);
                         }
 
                         while ($response = $connection->receive()) {
-                            /** @var DeferredFuture $deferred */
                             [$deferred] = $queue->shift();
                             if ($queue->isEmpty()) {
                                 $connection->unreference();
@@ -124,7 +123,6 @@ private function run(): void
                 $exception = new RedisConnectionException($exception->getMessage(), 0, $exception);
 
                 while (!$queue->isEmpty()) {
-                    /** @var DeferredFuture $deferred */
                     [$deferred] = $queue->shift();
                     $deferred->error($exception);
                 }

src/Protocol/RedisError.php

@@ -21,6 +21,7 @@ public function unwrap(): never
     public function getKind(): ?string
     {
         $prefix = \strtok($this->message, ' ');
+        \assert(is_string($prefix)); // For Psalm.
 
         // This is just a convention of Redis server, not part of the protocol
         if ($prefix === \strtoupper($prefix)) {

src/Protocol/RespParser.php

@@ -8,6 +8,8 @@
 
 /**
  * @psalm-type ParserGeneratorType = \Generator<int, int|string, string, RedisResponse>
+ *
+ * @psalm-suppress InvalidIterator
  */
 final class RespParser
 {

src/RedisClient.php

@@ -272,7 +272,11 @@ public function countBits(string $key, ?int $start = null, ?int $end = null): in
             $cmd[] = $start;
             $cmd[] = $end;
         } elseif (isset($start) || isset($end)) {
-            throw new \Error('Start and end must both be set or unset in countBits(), got start = ' . $start . ' and end = ' . $end);
+            throw new \Error(sprintf(
+                'Start and end must both be set or unset in countBits(), got start = %s and end = %s',
+                $start ?? 'null',
+                $end ?? 'null',
+            ));
         }
 
         return $this->execute('bitcount', ...$cmd);

src/RedisConfig.php

@@ -97,6 +97,7 @@ private function applyUri(string $uri): void
         try {
             $uri = Uri::new($uri);
         } catch (\Exception) {
+            /** @psalm-suppress ImplicitToStringCast */
             throw new RedisException('Invalid redis configuration URI: ' . $uri);
         }
 

src/Sync/RedisMutex.php

@@ -165,7 +165,11 @@ public function acquire(string $key): Lock
             $result = $this->redis->eval(
                 self::LOCK,
                 ["{$prefix}lock:{$key}", "{$prefix}lock-queue:{$key}"],
-                [$token, $this->options->getLockExpiration() * 1000, ($this->options->getLockExpiration() + $this->options->getLockTimeout()) * 1000]
+                [
+                    $token,
+                    $this->options->getLockExpiration() * 1000.0,
+                    ($this->options->getLockExpiration() + $this->options->getLockTimeout()) * 1000.0,
+                ],
             );
 
             if ($result < 1) {
@@ -176,7 +180,11 @@ public function acquire(string $key): Lock
                     $this->redis->getList("{$prefix}lock-queue:{$key}")->remove($token);
                     $this->unlock($key, $token);
 
-                    throw new RedisMutexException('Failed to acquire lock for ' . $key . ' within ' . $this->options->getLockTimeout() * 1000 . ' ms');
+                    throw new RedisMutexException(sprintf(
+                        'Failed to acquire lock for %s within %.5f ms',
+                        $key,
+                        $this->options->getLockTimeout() * 1000.0,
+                    ));
                 }
 
                 // A negative integer as reply means we're still in the queue and indicates the queue position.
@@ -265,7 +273,7 @@ static function () use (&$locks, $options, $redis, $logger): void {
                 \assert(!empty($locks));
 
                 $keys = [];
-                $arguments = [$options->getLockExpiration() * 1000];
+                $arguments = [$options->getLockExpiration() * 1000.0];
 
                 $prefix = $options->getKeyPrefix();