Skip to content

Commit 53a37ce

Browse files
an-altosiannmalwinkannie-altosChristelKrueger
committed
fix(qc): add procps-ng to QC containers and fix contributors manifest
CI on PR nf-core#205 surfaced two lint failures and container failures: - nf-core lint: the three Altos contributor entries in the manifest had a trailing comma after their last field. Groovy tolerates it but nf-core's linter converts the manifest to JSON and choked (JSONDecodeError). This also cascaded into spurious files_exist igenomes failures because the config-aware exemption depends on a parseable manifest. Removing the trailing commas clears both. - nf-test: QC processes died with exit status 1 (`Command 'ps' required by nextflow to collect task metrics cannot be found`). The micromamba-based QC containers lacked procps. Added conda-forge::procps-ng to all three QC environment.yml files (source of truth for docker/singularity/conda). Co-authored-by: Malwina Prater <mprater@altoslabs.com> Co-authored-by: Nell Nie <nnie@altoslabs.com> Co-authored-by: Christel Krueger <ckrueger@altoslabs.com>
1 parent f1dd859 commit 53a37ce

4 files changed

Lines changed: 9 additions & 3 deletions

File tree

modules/local/image_qc/environment.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ channels:
44
- conda-forge
55
- bioconda
66
dependencies:
7+
# procps-ng provides `ps`, required by Nextflow for task-metric collection
8+
- conda-forge::procps-ng=4.0.4
79
- conda-forge::python=3.11.0
810
- conda-forge::numpy=2.3.3
911
- conda-forge::pandas=2.3.2

modules/local/quarto/environment.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ channels:
44
- conda-forge
55
- bioconda
66
dependencies:
7+
# procps-ng provides `ps`, required by Nextflow for task-metric collection
8+
- conda-forge::procps-ng=4.0.4
79
- conda-forge::python=3.11.0
810
- conda-forge::quarto=1.6.42
911
- conda-forge::numpy=2.3.3

modules/local/transcript_qc/environment.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ channels:
44
- conda-forge
55
- bioconda
66
dependencies:
7+
# procps-ng provides `ps`, required by Nextflow for task-metric collection
8+
- conda-forge::procps-ng=4.0.4
79
- conda-forge::python=3.11.0
810
- conda-forge::numpy=2.3.3
911
- conda-forge::pandas=2.3.2

nextflow.config

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -409,17 +409,17 @@ manifest {
409409
[
410410
name: 'Malwina Prater',
411411
affiliation: 'Altos Labs',
412-
contribution: ['contributor'],
412+
contribution: ['contributor']
413413
],
414414
[
415415
name: 'Nell Nie',
416416
affiliation: 'Altos Labs',
417-
contribution: ['contributor'],
417+
contribution: ['contributor']
418418
],
419419
[
420420
name: 'Christel Krueger',
421421
affiliation: 'Altos Labs',
422-
contribution: ['contributor'],
422+
contribution: ['contributor']
423423
]
424424
]
425425
homePage = 'https://github.com/nf-core/spatialaxe'

0 commit comments

Comments
 (0)