Enhancement: Detect circular get() dependencies within module definitions

[kirich1409]

Problem

Extend existing CircularModuleDependency rule to detect definition-level circular get() chains within module lambda bodies, not just module-level includes() cycles.

Related Koin Issues

• Retrofit circular dependency instances creation InsertKoinIO/koin#334
• Maximum call stack size exceeded in compose multiplatform application InsertKoinIO/koin#2041

Current Coverage

CircularModuleDependency only checks includes() cycles between modules.

Proposed Enhancement

// Detect: circular get() dependencies
module {
    single { A(get<B>()) }
    single { B(get<A>()) }  // ❌ Stack overflow at runtime
}

Implementation Challenge

Requires semantic analysis to track get<T>() type resolution across definitions within the same module.

Priority

MEDIUM

Category

architecture

[kirich1409]

Status: deferred — requires semantic analysis not available in Detekt's single-file PSI pass.

Detecting circular get() dependencies (A depends on B, B depends on A) requires building a dependency graph across all providers in a module. Within a single file this is theoretically feasible, but real-world modules often split providers across multiple files — and the includes() chain may span multiple modules.

A heuristic limited to same-file cycles would catch only the simplest cases and might give a false sense of security. Cross-file implementation is not possible without multi-file analysis support.

Leaving open for future consideration.