Skip to content

External links in the What's New screen can crash with ActivityNotFoundException #301

Description

@jim-daf

I noticed that the What's New screen opens external links without handling the case where nothing on the device can open them.

In WhatsNewActivity.java the changelog WebView routes http and https links to startActivity(intent). If the user taps a link and there is no browser installed, or no app registered for that intent, startActivity throws ActivityNotFoundException and the screen crashes. This can happen on minimal or de-Googled devices and on restricted work profiles.

A small try/catch around the launch keeps the link working when a handler exists and avoids the crash otherwise. I will open a PR for it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions