-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() #48665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
860f92b to
7cc044b
Compare
|
@jonkeane do you mind if I ask to take a look when you find some time please 🙇 |
|
@github-actions crossbow submit test-r-arrow-backwards-compatibility |
|
Revision: 7cc044b Submitted crossbow builds: ursacomputing/crossbow @ actions-b70471dfc8
|
jonkeane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Would you mind adding a news entry about this since it's a new feature (+ feel free to add your name since you're a relatively new contributor and I don't think you yet have a news entry like this?)
@jonkeane do you mind if I ask to take a look when you find some time please 🙇
Sorry for the delay and thank you for the reminder ping
|
No problem! Thank you so much for your time 🫡 . |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 435d8ba. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Rationale for this change
Should address TODO added in commit 81e1fbc (ARROW-17665)
arrow/r/R/dplyr-funcs-string.R
Line 488 in 744f0ec
Implemented the argument intended to work.
What changes are included in this PR?
This PR Implement support for
keepNA = FALSEinbase::nchar()Are these changes tested?
Unittest was added.
Are there any user-facing changes?
Yes. Now
nchar(..., keepNA = FALSE)should work.