Fix UnusedVariable warnings across codebase (#37770)

supress warnings in tests

Author: stankiewicz

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

@@ -1567,7 +1567,6 @@ class BeamModulePlugin implements Plugin<Project> {
             "NullableTypeParameter",
             "NullableWildcard",
             "SuperCallToObjectMethod",
-            "UnusedVariable",
             // intended suppressions emerged in newer protobuf versions
             // For backward compatibility. Public method checked in before this check impl
             // Possible use in interface subclasses

runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java

@@ -90,7 +90,7 @@ public ProcessContinuation process(
     }
 
     @GetInitialRestriction
-    public OffsetRange getInitialRestriction(@Element Void element) {
+    public OffsetRange getInitialRestriction(@SuppressWarnings("unused") @Element Void element) {
       throw new UnsupportedOperationException("Should not be called in this test");
     }
   }
@@ -209,7 +209,8 @@ public void process(ProcessContext c, RestrictionTracker<OffsetRange, Long> trac
           }
 
           @GetInitialRestriction
-          public OffsetRange getInitialRestriction(@Element Void element) {
+          public OffsetRange getInitialRestriction(
+              @SuppressWarnings("unused") @Element Void element) {
             throw new UnsupportedOperationException("Should not be called in this test");
           }
         };
@@ -228,7 +229,8 @@ public void process(ProcessContext c, RestrictionTracker<OffsetRange, Long> trac
           }
 
           @GetInitialRestriction
-          public OffsetRange getInitialRestriction(@Element Void element) {
+          public OffsetRange getInitialRestriction(
+              @SuppressWarnings("unused") @Element Void element) {
             throw new UnsupportedOperationException("Should not be called in this test");
           }
         };

runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java

@@ -536,7 +536,8 @@ private static class MyDoFn extends DoFn<KV<String, Integer>, Integer> {
     public final StateSpec<ValueState<Integer>> intState = StateSpecs.value(VarIntCoder.of());
 
     @ProcessElement
-    public void processElement(ProcessContext c, @StateId(stateId) ValueState<Integer> state) {
+    public void processElement(
+        @SuppressWarnings("unused") ProcessContext c, @StateId(stateId) ValueState<Integer> state) {
       Integer currentValue = MoreObjects.firstNonNull(state.read(), 0);
       state.write(currentValue + 1);
     }

runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java

@@ -305,7 +305,8 @@ public void process(ProcessContext c, RestrictionTracker<SomeRestriction, Void>
     }
 
     @GetInitialRestriction
-    public SomeRestriction getInitialRestriction(@Element Integer elem) {
+    public SomeRestriction getInitialRestriction(
+        @SuppressWarnings("unused") @Element Integer elem) {
       return new SomeRestriction();
     }
   }
@@ -364,7 +365,7 @@ public void process(
     }
 
     @GetInitialRestriction
-    public OffsetRange getInitialRestriction(@Element Instant elem) {
+    public OffsetRange getInitialRestriction(@SuppressWarnings("unused") @Element Instant elem) {
       throw new IllegalStateException("Expected to be supplied explicitly in this test");
     }
 
@@ -446,7 +447,8 @@ public ProcessContinuation process(
     }
 
     @GetInitialRestriction
-    public SomeRestriction getInitialRestriction(@Element Integer elem) {
+    public SomeRestriction getInitialRestriction(
+        @SuppressWarnings("unused") @Element Integer elem) {
       return new SomeRestriction();
     }
   }
@@ -509,7 +511,7 @@ public ProcessContinuation process(
     }
 
     @GetInitialRestriction
-    public OffsetRange getInitialRestriction(@Element Integer elem) {
+    public OffsetRange getInitialRestriction(@SuppressWarnings("unused") @Element Integer elem) {
       throw new UnsupportedOperationException("Expected to be supplied explicitly in this test");
     }
   }
@@ -630,12 +632,15 @@ private enum State {
     private State state = State.BEFORE_SETUP;
 
     @ProcessElement
-    public void process(ProcessContext c, RestrictionTracker<SomeRestriction, Void> tracker) {
+    public void process(
+        @SuppressWarnings("unused") ProcessContext c,
+        @SuppressWarnings("unused") RestrictionTracker<SomeRestriction, Void> tracker) {
       assertEquals(State.INSIDE_BUNDLE, state);
     }
 
     @GetInitialRestriction
-    public SomeRestriction getInitialRestriction(@Element Integer element) {
+    public SomeRestriction getInitialRestriction(
+        @SuppressWarnings("unused") @Element Integer element) {
       return new SomeRestriction();
     }
 

runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java

@@ -142,7 +142,9 @@ public ResultT extractLatestAttempted() {
      * @param bundle The bundle being committed.
      * @param finalCumulative The final cumulative value for the given bundle.
      */
-    public void commitLogical(final CommittedBundle<?> bundle, final UpdateT finalCumulative) {
+    public void commitLogical(
+        @SuppressWarnings("unused") final CommittedBundle<?> bundle,
+        final UpdateT finalCumulative) {
       UpdateT current;
       do {
         current = finishedCommitted.get();

runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java

@@ -144,6 +144,6 @@ public void removesOnExceptionInFinishBundle() throws Exception {
 
   private static class TestFn extends DoFn<Object, Object> {
     @ProcessElement
-    public void processElement(ProcessContext c) throws Exception {}
+    public void processElement(@SuppressWarnings("unused") ProcessContext c) throws Exception {}
   }
 }

runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java

@@ -219,7 +219,7 @@ public void setup() {
     }
 
     @ProcessElement
-    public void processElement(ProcessContext c) throws Exception {}
+    public void processElement(@SuppressWarnings("unused") ProcessContext c) throws Exception {}
 
     @Teardown
     public void teardown() {

runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java

@@ -111,7 +111,7 @@ private ThrowsInCleanupFn(String message) {
     }
 
     @ProcessElement
-    public void processElement(ProcessContext c) throws Exception {}
+    public void processElement(@SuppressWarnings("unused") ProcessContext c) throws Exception {}
 
     @Teardown
     public void teardown() throws Exception {
@@ -165,6 +165,6 @@ public void describeTo(Description description) {
 
   private static class EmptyFn extends DoFn<Object, Object> {
     @ProcessElement
-    public void processElement(ProcessContext c) throws Exception {}
+    public void processElement(@SuppressWarnings("unused") ProcessContext c) throws Exception {}
   }
 }

runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java

@@ -47,7 +47,6 @@
 import org.apache.flink.configuration.StateBackendOptions;
 import org.apache.flink.configuration.TaskManagerOptions;
 import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings;
-import org.apache.flink.runtime.state.StateBackend;
 import org.apache.flink.runtime.util.EnvironmentInformation;
 import org.apache.flink.streaming.api.CheckpointingMode;
 import org.apache.flink.streaming.api.environment.LocalStreamEnvironment;
@@ -390,7 +389,6 @@ private static void configureCheckpointing(
   }
 
   private static void configureStateBackend(FlinkPipelineOptions options, Configuration config) {
-    final StateBackend stateBackend;
     if (options.getStateBackend() != null) {
       final String storagePath = options.getStateBackendStoragePath();
       Preconditions.checkArgument(

runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java

@@ -1306,12 +1306,12 @@ private static void initializeUserState(
 
   private static class NoOpDoFn<InputT, OutputT> extends DoFn<InputT, OutputT> {
     @ProcessElement
-    public void doNothing(ProcessContext context) {}
+    public void doNothing(@SuppressWarnings("unused") ProcessContext context) {}
   }
 
   private static class StableNoOpDoFn<InputT, OutputT> extends DoFn<InputT, OutputT> {
     @RequiresStableInput
     @ProcessElement
-    public void doNothing(ProcessContext context) {}
+    public void doNothing(@SuppressWarnings("unused") ProcessContext context) {}
   }
 }