Cherrypick kafka eos optimization

[stankiewicz]

Cherry pick #37648

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @stankiewicz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates an optimization for Kafka Exactly-Once Semantics (EOS) by introducing configurable triggering mechanisms for the Kafka sink. The changes provide greater flexibility in how records are batched and committed, allowing users to tune performance and latency for EOS writes to Kafka based on specific application requirements. This enhancement improves the overall efficiency and adaptability of the Kafka I/O connector.

Highlights

• Configurable EOS Triggering: Introduced new configuration options for Kafka Exactly-Once Semantics (EOS) triggering, allowing users to specify batching based on both element count and processing time timeout.
• Enhanced Windowing Logic: Modified the KafkaExactlyOnceSink to use a more flexible windowing trigger (AfterFirst with AfterPane.elementCountAtLeast and AfterProcessingTime.pastFirstElementInPane().plusDelayOf) for committing records, improving control over batch sizes and latency.
• API Extension for EOS Configuration: Added withEOSTriggerConfig methods to KafkaIO.WriteRecords and KafkaIO.Write to expose the new trigger parameters to users, enabling fine-grained control over EOS behavior.
• Schema and Translation Updates: Updated the Kafka I/O translation schema and logic to persist and retrieve the new EOS trigger configuration fields (eos_trigger_num_elements and eos_trigger_timeout_ms), ensuring compatibility and proper serialization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaExactlyOnceSink.java
  • Updated the windowing trigger logic for Kafka Exactly-Once Sink to support configurable batching based on element count and processing time timeout.
  • Reapplied windowing configuration after assigning sequential IDs to maintain desired batching.
• sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
  • Added new configuration options and methods to KafkaIO.WriteRecords and KafkaIO.Write for setting the Exactly-Once Semantics (EOS) trigger parameters (number of elements and timeout duration).
  • Included default values for eosTriggerNumElements and eosTriggerTimeout in the WriteRecords builder.
• sdks/java/io/kafka/upgrade/src/main/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslation.java
  • Modified the Kafka I/O translation to include new fields for EOS trigger configuration (eos_trigger_num_elements and eos_trigger_timeout_ms) in the transform schema and row conversion.
• sdks/java/io/kafka/upgrade/src/test/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslationTest.java
  • Updated the test schema mapping for Kafka I/O write transforms to include the newly added EOS trigger configuration fields.

Activity

• The pull request description indicates this is a cherry-pick from another repository, specifically Adds triggerring configuration to KafkaIO eos. #37648.
• Standard contribution guidelines and CI status checks are included in the pull request description.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[stankiewicz]

R: @kennknowles

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers