[Dataflow Streaming] Mark support for windmill state tag encoding v2#37683
[Dataflow Streaming] Mark support for windmill state tag encoding v2#37683arunpandianp wants to merge 3 commits intoapache:masterfrom
Conversation
The added experiment informs backend of the support and make jobs having this change eligible for state tag encoding v2. Post submit tests with v2 encoding passes and internal test suites pass with encoding v2.
Summary of ChangesHello @arunpandianp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a mechanism to signal support for version 2 of state tag encoding within Dataflow Streaming jobs. By adding a specific experiment flag, the Dataflow runner explicitly communicates to the backend that it is capable of handling this new encoding, thereby enabling jobs to utilize the improved state tag encoding v2. This change is crucial for rolling out and testing the new encoding standard. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
R: @scwhittle |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
...oogle-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
Show resolved
Hide resolved
...oogle-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
Outdated
Show resolved
Hide resolved
|
Some test errors due to explicit experiment checking |
|
Thanks, fixed the failing tests. |
The added experiment informs backend of the support and make jobs having this change eligible for state tag encoding v2.
Post submit tests with v2 encoding passes and internal test suites pass with encoding v2.
https://github.com/apache/beam/actions?query=workflow%3A%22%22PostCommit+Java+ValidatesRunner+Dataflow+Streaming+TagEncodingV2%22%22++