Skip to content

Comments

[Dataflow Streaming] Mark support for windmill state tag encoding v2#37683

Open
arunpandianp wants to merge 3 commits intoapache:masterfrom
arunpandianp:markTagV2Support
Open

[Dataflow Streaming] Mark support for windmill state tag encoding v2#37683
arunpandianp wants to merge 3 commits intoapache:masterfrom
arunpandianp:markTagV2Support

Conversation

@arunpandianp
Copy link
Contributor

The added experiment informs backend of the support and make jobs having this change eligible for state tag encoding v2.

Post submit tests with v2 encoding passes and internal test suites pass with encoding v2.

https://github.com/apache/beam/actions?query=workflow%3A%22%22PostCommit+Java+ValidatesRunner+Dataflow+Streaming+TagEncodingV2%22%22++

The added experiment informs backend of the support and make jobs having
this change eligible for state tag encoding v2.

Post submit tests with v2 encoding passes and internal test suites pass
with encoding v2.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @arunpandianp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a mechanism to signal support for version 2 of state tag encoding within Dataflow Streaming jobs. By adding a specific experiment flag, the Dataflow runner explicitly communicates to the backend that it is capable of handling this new encoding, thereby enabling jobs to utilize the improved state tag encoding v2. This change is crucial for rolling out and testing the new encoding standard.

Highlights

  • Dataflow Streaming State Tag Encoding v2 Support: An experiment flag streaming_engine_state_tag_encoding_v2_supported was added to Dataflow runner options. This flag informs the backend that the harness supports state tag encoding v2, making jobs eligible for this new feature.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
    • Added an experiment streaming_engine_state_tag_encoding_v2_supported to the Dataflow runner options when streaming is enabled.
    • Included a TODO comment regarding a missing options.setExperiments call for previously added experiments.
Activity
  • Post-submit tests with v2 encoding passed.
  • Internal test suites passed with encoding v2.
  • A link to GitHub Actions workflow for validation was provided.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@arunpandianp
Copy link
Contributor Author

R: @scwhittle

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@scwhittle
Copy link
Contributor

Some test errors due to explicit experiment checking

@arunpandianp
Copy link
Contributor Author

Thanks, fixed the failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants