Skip to content

Comments

[Dataflow Streaming] Remove dead code around redundant experiments#37684

Merged
scwhittle merged 1 commit intoapache:masterfrom
arunpandianp:fixexperiment
Feb 23, 2026
Merged

[Dataflow Streaming] Remove dead code around redundant experiments#37684
scwhittle merged 1 commit intoapache:masterfrom
arunpandianp:fixexperiment

Conversation

@arunpandianp
Copy link
Contributor

The experiments are not needed, they are also not set on the outgoing requests.

The experiments are not needed, they are also not set on the outgoing
requests.
@arunpandianp
Copy link
Contributor Author

R: @scwhittle

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @arunpandianp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code maintainability by eliminating obsolete experiment-related logic within the Dataflow runner. The removed code segments were responsible for conditionally adding specific streaming engine experiments, which have been deemed unnecessary and were not actively influencing the behavior of outgoing requests. This cleanup streamlines the codebase without altering the functional aspects of the Dataflow pipeline execution.

Highlights

  • Code Cleanup: Removed redundant code that conditionally added 'enable_streaming_engine' and 'enable_windmill_service' experiments. These experiments were identified as unnecessary and were not being set on outgoing requests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
    • Removed logic for adding 'enable_streaming_engine' and 'enable_windmill_service' experiments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@scwhittle scwhittle merged commit cb7caaa into apache:master Feb 23, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants