Skip to content

Add hashes for staged files and relevant validations in boot#37907

Draft
tarun-google wants to merge 7 commits intoapache:masterfrom
tarun-google:dataflow_vul
Draft

Add hashes for staged files and relevant validations in boot#37907
tarun-google wants to merge 7 commits intoapache:masterfrom
tarun-google:dataflow_vul

Conversation

@tarun-google
Copy link
Contributor

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Dataflow runner by adding SHA-256 hash validation for staged files. This change improves the integrity and security of artifacts used in Dataflow pipelines by ensuring that the files retrieved during pipeline execution match the expected hashes. The changes span across the Java, Go, and Python SDKs to ensure consistency across all supported languages.

Highlights

  • Staged File Hashes: This PR introduces SHA-256 hashes for staged files in the Dataflow runner, enhancing artifact verification.
  • Go SDK Integration: The Go SDK now injects full pipeline options into the context and extracts artifact hashes for validation.
  • Java SDK Integration: The Java SDK now sets artifact hashes in the Dataflow pipeline options.
  • Python SDK Integration: The Python SDK now includes artifact hashes when creating job descriptions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant