Use JUnit 5 convention for test method visibility

Author: garydgregory

commons-digester3-core/src/test/java/org/apache/commons/digester3/AsyncReaderTestCase.java

@@ -64,15 +64,15 @@ public void tearDown()
     }
 
     @Test
-    public void testParseFromClasspathURL()
+    void testParseFromClasspathURL()
         throws Exception
     {
         final Future<Employee> future = digester.asyncParse( getClass().getResource( "Test9.xml" ) );
         verify( future );
     }
 
     @Test
-    public void testParseFromFile()
+    void testParseFromFile()
         throws Exception
     {
         final Future<Employee> future = digester.asyncParse( new File( getProperty( "user.dir" ),
@@ -81,7 +81,7 @@ public void testParseFromFile()
     }
 
     @Test
-    public void testParseFromInputSource()
+    void testParseFromInputSource()
         throws Exception
     {
         final Future<Employee> future =
@@ -90,15 +90,15 @@ public void testParseFromInputSource()
     }
 
     @Test
-    public void testParseFromInputStream()
+    void testParseFromInputStream()
         throws Exception
     {
         final Future<Employee> future = digester.asyncParse( getClass().getResource( "Test9.xml" ).openStream() );
         verify( future );
     }
 
     @Test
-    public void testParseFromReader()
+    void testParseFromReader()
         throws Exception
     {
         final Future<Employee> future =
@@ -107,7 +107,7 @@ public void testParseFromReader()
     }
 
     @Test
-    public void testParseFromUri()
+    void testParseFromUri()
         throws Exception
     {
         final Future<Employee> future = digester.asyncParse( getClass().getResource( "Test9.xml" ).toExternalForm() );

commons-digester3-core/src/test/java/org/apache/commons/digester3/BeanPropertySetterRuleTestCase.java

@@ -53,7 +53,7 @@ public class BeanPropertySetterRuleTestCase
      * Test that you can successfully automatically set properties.
      */
     @Test
-    public void testAutomaticallySetProperties()
+    void testAutomaticallySetProperties()
         throws SAXException, IOException
     {
         final Digester digester = newLoader(new AbstractRulesModule()
@@ -84,7 +84,7 @@ protected void configure()
      * functioning correctly.
      */
     @Test
-    public void testDigesterBodyTextStack()
+    void testDigesterBodyTextStack()
         throws SAXException, IOException
     {
         final List<Rule> callOrder = new ArrayList<>();
@@ -120,7 +120,7 @@ protected void configure()
      * properly enforced.
      */
     @Test
-    public void testDigesterRuleCallOrder()
+    void testDigesterRuleCallOrder()
         throws SAXException, IOException
     {
 
@@ -172,7 +172,7 @@ protected void configure()
     }
 
     @Test
-    public void testExtractPropertyNameFromAttribute() throws Exception
+    void testExtractPropertyNameFromAttribute() throws Exception
     {
         final Employee expected = new Employee( "John", "Doe" );
 
@@ -198,7 +198,7 @@ protected void configure()
      * Test that you can successfully set a given property
      */
     @Test
-    public void testSetGivenProperty()
+    void testSetGivenProperty()
         throws SAXException, IOException
     {
         final Digester digester = newLoader(new AbstractRulesModule()
@@ -237,7 +237,7 @@ protected void configure()
      * Test that trying to set an unknown property throws an exception.
      */
     @Test
-    public void testSetUnknownProperty()
+    void testSetUnknownProperty()
     {
         final Digester digester = newLoader(new AbstractRulesModule()
         {

commons-digester3-core/src/test/java/org/apache/commons/digester3/CallMethodRuleTestCase.java

@@ -64,7 +64,7 @@ protected InputStream getInputStream( final String name )
      * several rule syntaxes.
      */
     @Test
-    public void testBasic() throws Exception
+    void testBasic() throws Exception
     {
         final Digester digester = newLoader( new AbstractRulesModule()
         {
@@ -97,7 +97,7 @@ protected void configure()
      * Test invoking an object which does not exist on the stack.
      */
     @Test
-    public void testCallInvalidTarget()
+    void testCallInvalidTarget()
     {
 
         final Digester digester = new Digester();
@@ -116,7 +116,7 @@ public void testCallInvalidTarget()
      * Test method calls with the CallMethodRule reading from the element body, with no CallParamMethod rules added.
      */
     @Test
-    public void testCallMethodOnly()
+    void testCallMethodOnly()
         throws Exception
     {
         final Digester digester = newLoader( new AbstractRulesModule()
@@ -145,7 +145,7 @@ protected void configure()
      * Test invoking an object which is at top-1 on the stack, like SetNextRule does...
      */
     @Test
-    public void testCallNext()
+    void testCallNext()
         throws Exception
     {
 
@@ -176,7 +176,7 @@ public void testCallNext()
      * Test invoking an object which is at the root of the stack, like SetRoot does...
      */
     @Test
-    public void testCallRoot()
+    void testCallRoot()
         throws Exception
     {
 
@@ -204,7 +204,7 @@ public void testCallRoot()
     }
 
     @Test
-    public void testFromStack()
+    void testFromStack()
         throws Exception
     {
 
@@ -266,7 +266,7 @@ public void testFromStack()
     }
 
     @Test
-    public void testNestedBody()
+    void testNestedBody()
         throws Exception
     {
 
@@ -325,7 +325,7 @@ public void testNestedBody()
      * CallMethodRule triggered on.
      */
     @Test
-    public void testOrderNestedPartA()
+    void testOrderNestedPartA()
         throws Exception
     {
         final Digester digester = newLoader( new AbstractRulesModule()
@@ -370,7 +370,7 @@ protected void configure()
      * on this call order so this test is present to ensure that no-one changes this behavior.
      */
     @Test
-    public void testOrderNestedPartB()
+    void testOrderNestedPartB()
         throws Exception
     {
         final Digester digester = newLoader( new AbstractRulesModule()
@@ -401,7 +401,7 @@ protected void configure()
      * This tests the call methods params enhancement that provides for more complex stack-based calls.
      */
     @Test
-    public void testParamsFromStack() throws Exception
+    void testParamsFromStack() throws Exception
     {
         final Digester digester = newLoader( new AbstractRulesModule()
         {
@@ -439,7 +439,7 @@ protected void configure()
 
     /** Test for the PathCallParamRule */
     @Test
-    public void testPathCallParam()
+    void testPathCallParam()
         throws Exception
     {
         final String xml =
@@ -465,7 +465,7 @@ public void testPathCallParam()
     }
 
     @Test
-    public void testPrimitiveReading()
+    void testPrimitiveReading()
         throws Exception
     {
         final StringReader reader =
@@ -518,7 +518,7 @@ public void testPrimitiveReading()
     }
 
     @Test
-    public void testProcessingHook()
+    void testProcessingHook()
         throws Exception
     {
 
@@ -568,7 +568,7 @@ protected void processMethodCallResult( final Object result )
      * float should all be acceptable as parameter types.
      */
     @Test
-    public void testSettingProperties() throws Exception
+    void testSettingProperties() throws Exception
     {
         Digester digester = newLoader( new AbstractRulesModule()
         {
@@ -649,7 +649,7 @@ protected void configure()
     }
 
     @Test
-    public void testTwoCalls()
+    void testTwoCalls()
         throws Exception
     {
 

commons-digester3-core/src/test/java/org/apache/commons/digester3/DTDValidationTestCase.java

@@ -34,7 +34,7 @@ public class DTDValidationTestCase
 {
 
     @Test
-    public void testDigesterDTDError()
+    void testDigesterDTDError()
     {
         Digester digester = newLoader( new AbstractRulesModule() {
 
@@ -76,7 +76,7 @@ public void warning( final SAXParseException e )
     }
 
     @Test
-    public void testDigesterLoaderFeatureDisabled()
+    void testDigesterLoaderFeatureDisabled()
         throws Exception
     {
        newLoader( new AbstractRulesModule()
@@ -98,7 +98,7 @@ protected void configure()
     }
 
     @Test
-    public void testDigesterNoDTDValidation()
+    void testDigesterNoDTDValidation()
         throws Exception
     {
         newLoader( new AbstractRulesModule()
@@ -117,7 +117,7 @@ protected void configure()
     }
 
     @Test
-    public void testDigesterValidation()
+    void testDigesterValidation()
         throws Exception
     {
         newLoader( new AbstractRulesModule()

commons-digester3-core/src/test/java/org/apache/commons/digester3/Digester133TestCase.java

@@ -92,7 +92,7 @@ protected void setPropertyOfMapBean( @SuppressWarnings( "rawtypes" ) final Map b
     }
 
     @Test
-    public void testDigester()
+    void testDigester()
         throws IOException, SAXException
     {
         final PropertyUtilsBean propertyUtils = new MyPropertyUtilsBean();

commons-digester3-core/src/test/java/org/apache/commons/digester3/Digester153TestCase.java

@@ -62,7 +62,7 @@ private void successfulConstructor( final RulesModule rulesModule )
     }
 
     @Test
-    public void testBasicConstructor()
+    void testBasicConstructor()
         throws Exception
     {
         final ObjectCreateRule createRule = new ObjectCreateRule( TestBean.class );
@@ -86,7 +86,7 @@ public void testBasicConstructor()
     }
 
     @Test
-    public void testBasicConstructorViaAnnotations()
+    void testBasicConstructorViaAnnotations()
         throws Exception
     {
         successfulConstructor( new FromAnnotationsRuleModule()
@@ -102,7 +102,7 @@ protected void configureRules()
     }
 
     @Test
-    public void testBasicConstructorViaBinder()
+    void testBasicConstructorViaBinder()
         throws Exception
     {
         successfulConstructor( new AbstractRulesModule()
@@ -123,7 +123,7 @@ protected void configure()
     }
 
     @Test
-    public void testBasicConstructorViaXML()
+    void testBasicConstructorViaXML()
         throws Exception
     {
         successfulConstructor( new FromXmlRulesModule()
@@ -139,7 +139,7 @@ protected void loadRules()
     }
 
     @Test
-    public void testBasicConstructorWithValuesNotFound()
+    void testBasicConstructorWithValuesNotFound()
         throws Exception
     {
         final ObjectCreateRule createRule = new ObjectCreateRule( TestBean.class );
@@ -157,7 +157,7 @@ public void testBasicConstructorWithValuesNotFound()
     }
 
     @Test
-    public void testConstructorWithAttributeAndElement()
+    void testConstructorWithAttributeAndElement()
         throws Exception
     {
         final ObjectCreateRule createRule = new ObjectCreateRule( TestBean.class );
@@ -184,7 +184,7 @@ public void testConstructorWithAttributeAndElement()
     }
 
     @Test
-    public void testConstructorWithClassDefinedInAttribute()
+    void testConstructorWithClassDefinedInAttribute()
         throws Exception
     {
         final ObjectCreateRule createRule = new ObjectCreateRule( null, "type" );

commons-digester3-core/src/test/java/org/apache/commons/digester3/Digester162TestCase.java

@@ -30,7 +30,7 @@ public final class Digester162TestCase
 {
 
     @Test
-    public void testAllowCreateObjectsWhichTypesAreSpecifiedInAttributeNameOnly()
+    void testAllowCreateObjectsWhichTypesAreSpecifiedInAttributeNameOnly()
         throws Exception
     {
         final Digester digester = newLoader( new AbstractRulesModule()

commons-digester3-core/src/test/java/org/apache/commons/digester3/Digester171TestCase.java

@@ -33,7 +33,7 @@ public class Digester171TestCase
 {
 
     @Test
-    public void testDefaultThrowingErrorHandler()
+    void testDefaultThrowingErrorHandler()
         throws Exception
     {
         final ErrorHandler customErrorHandler = new DefaultThrowingErrorHandler();
@@ -55,7 +55,7 @@ protected void configure()
     }
 
     @Test
-    public void testNoErrorHandler()
+    void testNoErrorHandler()
         throws Exception
     {
         newLoader( new AbstractRulesModule()