Skip to content

Commit d59da16

Browse files
lordgarrishAndrei Nadyktov
authored andcommitted
IGNITE-22530 Add minor refactoring
1 parent 6d98056 commit d59da16

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcConsumerEx.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,20 @@
1717

1818
package org.apache.ignite.internal.cdc;
1919

20-
import java.nio.file.Path;
2120
import java.util.List;
2221

2322
import org.apache.ignite.cdc.CdcConsumer;
2423
import org.apache.ignite.metric.MetricRegistry;
2524

2625
/**
27-
* Extended CdcConsumer interface which provides overloaded {@link CdcConsumerEx#start(MetricRegistry, Path, List)} method
26+
* Extended CdcConsumer interface which provides overloaded {@link CdcConsumerEx#start(MetricRegistry, List)} method
2827
* required for CDC regex filters.
2928
*/
3029
public interface CdcConsumerEx extends CdcConsumer {
3130
/**
3231
* Starts the consumer.
3332
* @param mreg Metric registry for consumer specific metrics.
34-
* @param cdcDir Path to Change Data Capture Directory.
3533
* @param cacheNames List of cache names.
3634
*/
37-
void start(MetricRegistry mreg, Path cdcDir, List<String> cacheNames);
35+
void start(MetricRegistry mreg, List<String> cacheNames);
3836
}

modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import org.apache.ignite.cdc.CdcConsumer;
4444
import org.apache.ignite.cdc.CdcEvent;
4545
import org.apache.ignite.cdc.TypeMapping;
46-
import org.apache.ignite.configuration.CacheConfiguration;
4746
import org.apache.ignite.configuration.DataRegionConfiguration;
4847
import org.apache.ignite.configuration.DataStorageConfiguration;
4948
import org.apache.ignite.configuration.IgniteConfiguration;
@@ -351,8 +350,7 @@ public void runX() throws Exception {
351350
.map(data -> data.configuration().getName())
352351
.collect(Collectors.toList());
353352

354-
consumer.start(mreg, kctx.metric().registry(metricName("cdc", "consumer")), ft.walCdc().toPath(),
355-
cacheNames);
353+
consumer.start(mreg, kctx.metric().registry(metricName("cdc", "consumer")), cacheNames);
356354

357355
started = true;
358356

modules/core/src/main/java/org/apache/ignite/internal/cdc/WalRecordsConsumer.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
package org.apache.ignite.internal.cdc;
1919

20-
import java.nio.file.Path;
2120
import java.util.EnumSet;
2221
import java.util.Iterator;
2322
import java.util.List;
@@ -188,13 +187,13 @@ public void onCacheDestroyEvents(Iterator<Integer> caches) {
188187
*
189188
* @param cdcReg CDC metric registry.
190189
* @param cdcConsumerReg CDC consumer metric registry.
191-
* @param cdcDir Path to Change Data Capture Directory.
192190
* @param cacheNames List of cache names.
193191
* @throws IgniteCheckedException If failed.
194192
*/
195-
public void start(MetricRegistryImpl cdcReg, MetricRegistryImpl cdcConsumerReg, Path cdcDir, List<String> cacheNames) throws IgniteCheckedException {
193+
public void start(MetricRegistryImpl cdcReg, MetricRegistryImpl cdcConsumerReg, List<String> cacheNames)
194+
throws IgniteCheckedException {
196195
if (consumer instanceof CdcConsumerEx)
197-
((CdcConsumerEx) consumer).start(cdcConsumerReg, cdcDir, cacheNames);
196+
((CdcConsumerEx)consumer).start(cdcConsumerReg, cacheNames);
198197
else
199198
consumer.start(cdcConsumerReg);
200199

@@ -207,7 +206,7 @@ public void start(MetricRegistryImpl cdcReg, MetricRegistryImpl cdcConsumerReg,
207206

208207
/**
209208
* Stops the consumer.
210-
* This methods can be invoked only after {@link #start(MetricRegistryImpl, MetricRegistryImpl, Path, List)}.
209+
* This methods can be invoked only after {@link #start(MetricRegistryImpl, MetricRegistryImpl, List)}.
211210
*/
212211
public void stop() {
213212
consumer.stop();

0 commit comments

Comments
 (0)