Skip to content

fix when shenyu register by consul, the prop 'metadata-path' config is invalid and error occurred in MetaDataRegister when the path had special symbol '{}',such as '/path/{id}/{name}'#4885

Merged
yu199195 merged 9 commits intoapache:masterfrom
yu1183688986:consul
Jul 25, 2023

Conversation

@yu1183688986
Copy link
Copy Markdown
Contributor

@yu1183688986 yu1183688986 commented Jul 20, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

…s invalid and error occurred in MetaDataRegister when the path had special symbol '{}',such as '/path/{id}/{name}'.

Signed-off-by: 清溪先生 <usfree2021@163.com>
Signed-off-by: 清溪先生 <usfree2021@163.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 20, 2023

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.90%. Comparing base (7822ec0) to head (7153675).
⚠️ Report is 762 commits behind head on master.

Files with missing lines Patch % Lines
.../client/consul/ConsulClientRegisterRepository.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4885      +/-   ##
============================================
- Coverage     64.02%   63.90%   -0.12%     
- Complexity     8236     8240       +4     
============================================
  Files          1168     1169       +1     
  Lines         34459    34541      +82     
  Branches       3091     3107      +16     
============================================
+ Hits          22062    22075      +13     
- Misses        10636    10702      +66     
- Partials       1761     1764       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yu199195 yu199195 merged commit 3d3cafe into apache:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants