removed 3 trivial getter/setter

Author: onkar717

test/org/apache/catalina/valves/TestLoadBalancerDrainingValveUnit.java

@@ -32,26 +32,11 @@
 import org.easymock.IMocksControl;
 
 /**
- * Unit tests for {@link LoadBalancerDrainingValve} covering property getters/setters
- * and URI manipulation behaviours not covered by the parameterised integration test.
+ * Unit tests for {@link LoadBalancerDrainingValve} covering URI manipulation behaviours
+ * not covered by the parameterised integration test.
  */
 public class TestLoadBalancerDrainingValveUnit {
 
-    @Test
-    public void testGetSetProperties() {
-        LoadBalancerDrainingValve valve = new LoadBalancerDrainingValve();
-
-        // setRedirectStatusCode has no corresponding getter; verify it does not throw
-        valve.setRedirectStatusCode(302);
-
-        valve.setIgnoreCookieName("testCookie");
-        Assert.assertEquals("testCookie", valve.getIgnoreCookieName());
-
-        valve.setIgnoreCookieValue("testValue");
-        Assert.assertEquals("testValue", valve.getIgnoreCookieValue());
-    }
-
-
     /**
      * collapseLeadingSlashes() is the private static helper that normalises URIs
      * before issuing the redirect.  Test it directly via reflection.

test/org/apache/catalina/valves/TestSSLValve.java

@@ -405,30 +405,6 @@ private void assertCertificateParsed() throws Exception {
     }
 
 
-    @Test
-    public void testGetSetProperties() {
-        SSLValve v = new SSLValve();
-
-        v.setSslClientCertHeader("custom_cert");
-        Assert.assertEquals("custom_cert", v.getSslClientCertHeader());
-
-        v.setSslClientEscapedCertHeader("custom_escaped");
-        Assert.assertEquals("custom_escaped", v.getSslClientEscapedCertHeader());
-
-        v.setSslSecureProtocolHeader("custom_protocol");
-        Assert.assertEquals("custom_protocol", v.getSslSecureProtocolHeader());
-
-        v.setSslCipherHeader("custom_cipher");
-        Assert.assertEquals("custom_cipher", v.getSslCipherHeader());
-
-        v.setSslSessionIdHeader("custom_session");
-        Assert.assertEquals("custom_session", v.getSslSessionIdHeader());
-
-        v.setSslCipherUserKeySizeHeader("custom_keysize");
-        Assert.assertEquals("custom_keysize", v.getSslCipherUserKeySizeHeader());
-    }
-
-
     @Test
     public void testCustomHeaderNames() throws Exception {
         SSLValve customValve = new SSLValve();

test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java

@@ -215,18 +215,6 @@ public void run() {
     }
 
 
-    @Test
-    public void testGetSetProperties() {
-        StuckThreadDetectionValve valve = new StuckThreadDetectionValve();
-
-        valve.setThreshold(300);
-        Assert.assertEquals(300, valve.getThreshold());
-
-        valve.setInterruptThreadThreshold(600);
-        Assert.assertEquals(600, valve.getInterruptThreadThreshold());
-    }
-
-
     @Test
     public void testGetInterruptedThreadsCount() throws Exception {
         StickingServlet stickingServlet = new StickingServlet(TimeUnit.SECONDS.toMillis(20L));
@@ -254,13 +242,10 @@ public void run() {
             }
         };
         asyncThread.start();
-        try {
-            asyncThread.join(20000);
-            Assert.assertFalse(asyncThread.isAlive());
-        } finally {
-            // Interrupted thread count should now be > 0
-            Assert.assertTrue(stickingServlet.wasInterrupted);
-            Assert.assertTrue(valve.getInterruptedThreadsCount() > 0);
-        }
+        asyncThread.join(20000);
+        // check that we did not reach the join timeout
+        Assert.assertFalse(asyncThread.isAlive());
+        Assert.assertTrue(stickingServlet.wasInterrupted);
+        Assert.assertTrue(valve.getInterruptedThreadsCount() > 0);
     }
 }