merge: feat-documentsdb into feat-vectordb

Author: premtsd-code

bugs.md

@@ -0,0 +1,56 @@
+# VectorDB Console Bugs
+
+> VectorsDB shares the `collection-[collection]` route with documentsdb -- no separate pages needed.
+> The `sdk.ts` abstraction (`useDatabaseSdk`) already handles all three types.
+> The `.bind()` ternary in spreadsheet.svelte is intentional -- sdk.ts returns `Record` types but the spreadsheet expects raw `Models.Document`. Refactoring would require touching the entire document pipeline.
+
+## ~~Critical -- Will break vectorsdb in production~~ FIXED
+
+### ~~1. `collection-[collection]/+page.ts` -- listDocuments hardcoded to `documentsDB`~~ FIXED
+
+### ~~2. `collection-[collection]/+page.svelte` -- EmptySheet type hardcoded to `"documentsdb"`~~ FIXED
+
+### ~~3. `empty.svelte` -- vectorsdb gets tablesdb layout~~ FIXED
+
+### ~~4. `empty.svelte` CSS -- no vectorsdb selector~~ FIXED
+
+### ~~5. `empty.svelte` -- index-only check excludes vectorsdb~~ FIXED
+
+---
+
+## ~~Major -- UX bugs~~ FIXED
+
+### ~~6. Keyboard hint hardcodes `Cmd` (macOS only)~~ FIXED
+
+### 7. `Mod-g` conflicts with browser "Find next"
+
+**File:** `editor/view.svelte:1137`
+`Cmd+G` / `Ctrl+G` is the standard "Find next" shortcut after `Cmd+F`.
+**Status:** Deprioritized -- CodeMirror captures keys when focused, minor edge case.
+
+---
+
+## Minor -- Cleanup / consistency
+
+### 9. `getCollectionService()` type signature too broad
+
+**File:** `(entity)/helpers/sdk.ts:118`
+Accepts all `DatabaseType` but only handles `documentsdb` and `vectorsdb`. Calling with `legacy` or `tablesdb` throws at runtime.
+**Fix:** Narrow parameter type to `Extract<DatabaseType, 'documentsdb' | 'vectorsdb'>`.
+
+### 10. `create.svelte` -- `dimension` not reset on modal close
+
+**File:** `(entity)/views/create.svelte`
+`id` and `name` are reset in `updateAndCleanup()` but `dimension` is not. Reopening the modal after creating a collection with dimension 1536 will still show 1536.
+**Fix:** Add `dimension = 768;` to the reset paths.
+
+### 11. `create.svelte` -- No max bound on dimension input
+
+**File:** `(entity)/views/create.svelte`
+The `InputNumber` has `min={1}` but no `max`. A user could enter an arbitrarily large value.
+**Fix:** Add a sensible `max` (e.g., 16384).
+
+### 12. Magic number `768` repeated
+
+**Files:** `create.svelte:39`, `+layout.svelte:277`
+**Fix:** Extract to a constant like `DEFAULT_VECTOR_DIMENSION`.

bun.lock

@@ -20,7 +20,7 @@
     },
     "dependencies": {
         "@ai-sdk/svelte": "^1.1.24",
-        "@appwrite.io/console": "https://pkg.vc/-/@appwrite/@appwrite.io/console@f16c734",
+        "@appwrite.io/console": "https://pkg.vc/-/@appwrite/@appwrite.io/console@e259e61",
         "@appwrite.io/pink-icons": "0.25.0",
         "@appwrite.io/pink-icons-svelte": "https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@bfe7ce3",
         "@appwrite.io/pink-legacy": "^1.0.3",
@@ -49,6 +49,7 @@
         "dayjs": "^1.11.13",
         "deep-equal": "^2.2.3",
         "echarts": "^5.6.0",
+        "flatted": "^3.4.2",
         "ignore": "^6.0.2",
         "json5": "^2.2.3",
         "nanoid": "^5.1.5",

package.json

@@ -26,8 +26,8 @@
             sizes="120x120"
             href="%sveltekit.assets%/logos/apple-touch-icon-120x120.png" />
 
-        <!-- apple web app meta tags -->
-        <meta name="apple-mobile-web-app-capable" content="yes" />
+        <!-- web app / standalone display meta tags -->
+        <meta name="mobile-web-app-capable" content="yes" />
         <meta name="apple-mobile-web-app-title" content="Appwrite Console" />
         <meta name="apple-mobile-web-app-status-bar-style" content="default" />
 

src/app.html

@@ -236,6 +236,7 @@ export enum Submit {
     UserUpdatePassword = 'submit_user_update_password',
     UserUpdatePhone = 'submit_user_update_phone',
     UserUpdateMfa = 'submit_user_update_mfa',
+    UserUpdateImpersonation = 'submit_user_update_impersonation',
     UserUpdatePreferences = 'submit_user_update_preferences',
     UserUpdateStatus = 'submit_user_update_status',
     UserUpdateVerificationEmail = 'submit_user_update_verification_email',
@@ -329,6 +330,7 @@ export enum Submit {
     FunctionUpdateSchedule = 'submit_function_update_schedule',
     FunctionUpdateConfiguration = 'submit_function_update_configuration',
     FunctionUpdateLogging = 'submit_function_update_logging',
+    FunctionUpdateResourceLimits = 'submit_function_update_resource_limits',
     FunctionUpdateTimeout = 'submit_function_update_timeout',
     FunctionUpdateEvents = 'submit_function_update_events',
     FunctionUpdateScopes = 'submit_function_key_update_scopes',
@@ -453,6 +455,7 @@ export enum Submit {
     SiteUpdateEvents = 'submit_site_update_events',
     SiteUpdateScopes = 'submit_site_key_update_scopes',
     SiteUpdateBuildSettings = 'submit_site_update_build_settings',
+    SiteUpdateResourceLimits = 'submit_site_update_resource_limits',
     SiteUpdateSinglePageApplication = 'submit_site_update_single_page_application',
     SiteConnectRepo = 'submit_site_connect_repo',
     SiteRedeploy = 'submit_site_redeploy',

src/lib/actions/analytics.ts

@@ -24,10 +24,10 @@ import {
     TablesDB,
     Domains,
     DocumentsDB,
+    Webhooks,
     Realtime,
     Organizations,
-    VectorsDB,
-    Webhooks
+    VectorsDB
 } from '@appwrite.io/console';
 import { Sources } from '$lib/sdk/sources';
 import {

src/lib/stores/sdk.ts

@@ -7,6 +7,7 @@
     import UpdateName from './updateName.svelte';
     import UpdatePassword from './updatePassword.svelte';
     import UpdatePhone from './updatePhone.svelte';
+    import UpdateImpersonation from './updateImpersonation.svelte';
     import UpdatePrefs from './updatePrefs.svelte';
     import UpdateStatus from './updateStatus.svelte';
     import type { PageData } from './$types';
@@ -22,6 +23,7 @@
     <UpdatePassword />
     <UpdateLabels />
     <UpdatePrefs />
+    <UpdateImpersonation />
     <UpdateMfa />
     <DangerZone project={data.project} />
 </Container>

src/routes/(console)/project-[region]-[project]/auth/user-[user]/+page.svelte

@@ -0,0 +1,84 @@
+<script lang="ts">
+    import { invalidate } from '$app/navigation';
+    import { page } from '$app/state';
+    import { Submit, trackError, trackEvent } from '$lib/actions/analytics';
+    import { CardGrid } from '$lib/components';
+    import { Dependencies } from '$lib/constants';
+    import { Button, Form } from '$lib/elements/forms';
+    import { addNotification } from '$lib/stores/notifications';
+    import { sdk } from '$lib/stores/sdk';
+    import { Alert, Layout, Link, Selector, Typography } from '@appwrite.io/pink-svelte';
+    import { onMount } from 'svelte';
+    import { user } from './store';
+
+    let impersonator = false;
+
+    $: currentImpersonator = Boolean($user?.impersonator);
+
+    onMount(() => {
+        impersonator = currentImpersonator;
+    });
+
+    async function updateImpersonator() {
+        try {
+            await sdk.forProject(page.params.region, page.params.project).users.updateImpersonator({
+                userId: $user.$id,
+                impersonator
+            });
+
+            await invalidate(Dependencies.USER);
+
+            addNotification({
+                message: `Impersonation capability has been ${impersonator ? 'enabled' : 'disabled'}`,
+                type: 'success'
+            });
+            trackEvent(Submit.UserUpdateImpersonation);
+        } catch (error) {
+            impersonator = currentImpersonator;
+
+            addNotification({
+                message: error.message,
+                type: 'error'
+            });
+            trackError(error, Submit.UserUpdateImpersonation);
+        }
+    }
+</script>
+
+<Form onSubmit={updateImpersonator}>
+    <CardGrid>
+        <svelte:fragment slot="title">User impersonation</svelte:fragment>
+        <svelte:fragment slot="aside">
+            <Layout.Stack gap="m">
+                <Selector.Switch
+                    id="user-impersonation"
+                    bind:checked={impersonator}
+                    label="User impersonation">
+                    <svelte:fragment slot="description">
+                        <div class="u-margin-block-start-8">
+                            <Typography.Text variant="m-400">
+                                Enabling this option allows this user to impersonate other users
+                                through your app using the Appwrite Client SDK.
+                                <Link.Anchor
+                                    target="_blank"
+                                    rel="noopener noreferrer"
+                                    href="https://appwrite.io/docs/products/auth">
+                                    Learn more.
+                                </Link.Anchor>
+                            </Typography.Text>
+                        </div>
+                    </svelte:fragment>
+                </Selector.Switch>
+
+                <Alert.Inline status="info">
+                    Only grant this permission to trusted operator or support accounts. Actions are
+                    logged under the account that initiated impersonation.
+                </Alert.Inline>
+            </Layout.Stack>
+        </svelte:fragment>
+
+        <svelte:fragment slot="actions">
+            <Button disabled={impersonator === currentImpersonator} submit>Update</Button>
+        </svelte:fragment>
+    </CardGrid>
+</Form>

src/routes/(console)/project-[region]-[project]/auth/user-[user]/updateImpersonation.svelte

@@ -0,0 +1,39 @@
+import type { Page } from '@sveltejs/kit';
+import { getContext, setContext } from 'svelte';
+import {
+    type AnalyticsResult,
+    type DatabaseSdkResult,
+    type DependenciesResult,
+    type TerminologyResult,
+    useAnalytics,
+    useDependencies,
+    useTerminology,
+    useDatabaseSdk
+} from '$database/(entity)';
+
+const TERMINOLOGIES_KEY = Symbol('terminologies');
+
+export type Terminologies = {
+    analytics: AnalyticsResult;
+    terminology: TerminologyResult;
+    dependencies: DependenciesResult;
+    databaseSdk: DatabaseSdkResult;
+};
+
+export function getTerminologies(): Terminologies {
+    return getContext<Terminologies>(TERMINOLOGIES_KEY);
+}
+
+export function setTerminologies(page: Page) {
+    setContext(TERMINOLOGIES_KEY, buildTerminologies(page));
+}
+
+function buildTerminologies(page: Page): Terminologies {
+    const terminology = useTerminology(page);
+    return {
+        terminology,
+        analytics: useAnalytics(terminology),
+        dependencies: useDependencies(terminology),
+        databaseSdk: useDatabaseSdk(page, terminology)
+    };
+}

src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/helpers/init.ts

@@ -0,0 +1,68 @@
+<script lang="ts">
+    import { onMount } from 'svelte';
+    import { page } from '$app/state';
+    import { sdk } from '$lib/stores/sdk';
+    import { Activity } from '$lib/layout';
+    import { rowActivitySheet } from '../store';
+    import { pageToOffset } from '$lib/helpers/load';
+    import { type Models, Query } from '@appwrite.io/console';
+    import { Skeleton } from '@appwrite.io/pink-svelte';
+
+    let limit = 25; /* default */
+    let offset = $state(0);
+    let loading = $state(true);
+    let rowActivityLogs = $state<Models.LogList | null>(null);
+
+    onMount(loadRowLogs);
+
+    async function loadRowLogs(event?: CustomEvent<number>) {
+        loading = true;
+
+        if (event) {
+            offset = pageToOffset(event.detail, limit);
+        }
+
+        const row = $rowActivitySheet.row;
+
+        rowActivityLogs = await sdk
+            .forProject(page.params.region, page.params.project)
+            .tablesDB.listRowLogs({
+                databaseId: row.$databaseId,
+                tableId: row.$tableId,
+                rowId: row.$id,
+                queries: [Query.limit(limit), Query.offset(offset)]
+            });
+
+        loading = false;
+    }
+</script>
+
+{#if loading}
+    <div style:margin-block="" style:margin-inline-end="2.25rem">
+        <!--<Skeleton variant="line" height={25} width="25%" />-->
+        <Skeleton variant="line" height={40} width="auto" />
+    </div>
+{:else if rowActivityLogs}
+    <div class="row-activity-wrapper">
+        <Activity
+            {limit}
+            {offset}
+            insideSideSheet
+            on:page={loadRowLogs}
+            logs={rowActivityLogs}
+            useCreateLinkForPagination={false} />
+    </div>
+{/if}
+
+<style lang="scss">
+    .row-activity-wrapper {
+        & :global(.console-container) {
+            margin-inline: unset;
+            padding-inline-end: unset;
+
+            @media (max-width: 768px) {
+                margin-block: 0.5rem;
+            }
+        }
+    }
+</style>