Warn when a desktop profile's greeter can't log in without a regular user

Author: dylanmtaylor

archinstall/scripts/guided.py

@@ -2,6 +2,7 @@
 import sys
 import time
 
+from archinstall.default_profiles.profile import GreeterType
 from archinstall.lib.applications.application_handler import ApplicationHandler
 from archinstall.lib.args import ArchConfig, ArchConfigHandler
 from archinstall.lib.authentication.authentication_handler import AuthenticationHandler
@@ -11,6 +12,7 @@
 from archinstall.lib.general.general_menu import PostInstallationAction, select_post_installation
 from archinstall.lib.global_menu import GlobalMenu
 from archinstall.lib.installer import Installer, accessibility_tools_in_use, run_custom_user_commands
+from archinstall.lib.menu.helpers import Confirmation
 from archinstall.lib.menu.util import delayed_warning
 from archinstall.lib.mirror.mirror_handler import MirrorListHandler
 from archinstall.lib.models import Bootloader
@@ -24,6 +26,36 @@
 from archinstall.tui.ui.components import tui
 
 
+def _has_greeter_without_user(config: ArchConfig) -> bool:
+	"""Check if the user selected a desktop with a greeter that can't log in without a regular user."""
+	profile_config = config.profile_config
+	if not profile_config or not profile_config.profile:
+		return False
+
+	if not profile_config.profile.is_desktop_profile():
+		return False
+
+	has_users = config.auth_config and config.auth_config.users
+	if has_users:
+		return False
+
+	# These greeters only show users with UID >= 1000 and have no manual login by default
+	problematic_greeters = {GreeterType.Sddm}
+
+	return any(p.default_greeter_type in problematic_greeters for p in profile_config.profile.current_selection)
+
+
+async def _warn_greeter_no_user() -> bool:
+	prompt = (
+		'The desktop profile you have selected needs a regular user created to log in. '
+		'One has not been created. '
+		'Would you like to continue without a regular user?\n'
+	)
+
+	result = await Confirmation(header=prompt, allow_skip=False, preset=False).show()
+	return result.get_value()
+
+
 def show_menu(
 	arch_config_handler: ArchConfigHandler,
 	mirror_list_handler: MirrorListHandler,
@@ -223,6 +255,10 @@ def main(arch_config_handler: ArchConfigHandler | None = None) -> None:
 			debug('Installation aborted')
 			aborted = True
 
+		if not aborted and _has_greeter_without_user(arch_config_handler.config):
+			if not tui.run(_warn_greeter_no_user):
+				aborted = True
+
 		if aborted:
 			return main(arch_config_handler)