drm/amdgpu: don't attach the tlb fence for SI

alexdeucher · heftig · commit e0f61e440ba3 · 2025-12-12T20:09:39.000+01:00
SI hardware doesn't support pasids, user mode queues, or KIQ/MES so there is no need for this. Doing so results in a segfault as these callbacks are non-existent for SI. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4744 Fixes: f3854e0 ("drm/amdgpu: attach tlb fence to the PTs update") Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Cherry-picked-for: https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/issues/166
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1066,7 +1066,9 @@ amdgpu_vm_tlb_flush(struct amdgpu_vm_update_params *params,
 	}
 
 	/* Prepare a TLB flush fence to be attached to PTs */
-	if (!params->unlocked) {
+	if (!params->unlocked &&
+	    /* SI doesn't support pasid or KIQ/MES */
+	    params->adev->family > AMDGPU_FAMILY_SI) {
 		amdgpu_vm_tlb_fence_create(params->adev, vm, fence);
 
 		/* Makes sure no PD/PT is freed before the flush */

Original file line number	Diff line number	Diff line change
`@@ -1066,7 +1066,9 @@ amdgpu_vm_tlb_flush(struct amdgpu_vm_update_params *params,`
`1066`	`1066`	`}`
`1067`	`1067`
`1068`	`1068`	`/* Prepare a TLB flush fence to be attached to PTs */`
`1069`		`- if (!params->unlocked) {`
	`1069`	`+ if (!params->unlocked &&`
	`1070`	`+ /* SI doesn't support pasid or KIQ/MES */`
	`1071`	`+ params->adev->family > AMDGPU_FAMILY_SI) {`
`1070`	`1072`	`amdgpu_vm_tlb_fence_create(params->adev, vm, fence);`
`1071`	`1073`
`1072`	`1074`	`/* Makes sure no PD/PT is freed before the flush */`