Enhance type safety by updating recalculateTargets response handling and defining RecalculateTargetsResponse type

Author: MattG57

frontend/src/app/main/copilot/copilot-value-modeling/copilot-value-modeling.component.ts

@@ -2,7 +2,7 @@ import { Component, inject, OnInit } from '@angular/core';
 import { MatTableModule } from '@angular/material/table';
 import { Subject, takeUntil } from 'rxjs';
 import { InstallationsService } from '../../../services/api/installations.service';
-import { Target, Targets, TargetsService } from '../../../services/api/targets.service';
+import { Target, Targets, TargetsService, RecalculateTargetsResponse } from '../../../services/api/targets.service';
 import { MatIconModule } from '@angular/material/icon';
 import { MatButtonModule } from '@angular/material/button';
 import { MAT_DIALOG_DATA, MatDialog, MatDialogActions, MatDialogContent, MatDialogRef, MatDialogTitle } from '@angular/material/dialog';
@@ -150,8 +150,9 @@ export class CopilotValueModelingComponent implements OnInit {
 
   resetTargets() {
     // Call the backend endpoint to recalculate targets
-    this.targetsService.recalculateTargets().subscribe((result: any) => {
-      const targets = result.targets || result; // handle both {targets, logs} and just targets
+    this.targetsService.recalculateTargets().subscribe((result: RecalculateTargetsResponse) => {
+      // Handle response format - could be {targets: Targets, logs?: any[]} or just Targets
+      const targets = 'targets' in result ? result.targets : result as Targets;
       this.orgDataSource = this.transformTargets(targets.org);
       this.userDataSource = this.transformTargets(targets.user);
       this.impactDataSource = this.transformTargets(targets.impact);

frontend/src/app/services/api/targets.service.ts

@@ -34,6 +34,14 @@ export interface Targets {
   }
 }
 
+export interface TargetsCalculationResponse {
+  targets: Targets;
+  logs?: any[]; // Optional calculation logs
+}
+
+// Union type to handle both response formats
+export type RecalculateTargetsResponse = TargetsCalculationResponse | Targets;
+
 @Injectable({
   providedIn: 'root'
 })
@@ -80,7 +88,7 @@ export class TargetsService {
 
   recalculateTargets() {
     // Calls the backend endpoint to recalculate targets
-    return this.http.get<any>(`${this.apiUrl}/calculate`);
+    return this.http.get<RecalculateTargetsResponse>(`${this.apiUrl}/calculate`);
   }
 }