Skip to content

Commit a8663d2

Browse files
author
Lucas McDonald
committed
ci(esdk): add version-ambiguity reason to duplicate-aws-lc 'why'
1 parent a1aa24e commit a8663d2

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/rust_duplicate_deps.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
# Fails CI if a direct aws-lc-sys / aws-lc-fips-sys version differs from the one
22
# aws-lc-rs pulls in transitively. Two versions compile two separate copies of
33
# AWS-LC -- roughly 2x the native build time and a larger binary for customers
4-
# building our code. The fix is to match the direct -sys version to aws-lc-rs.
4+
# building our code -- and leave it unclear which version is actually in use, so
5+
# behavior can diverge if the two differ. The fix is to match the direct -sys
6+
# version to aws-lc-rs.
57
name: Rust Duplicate aws-lc Dependency Check
68

79
on:
@@ -71,7 +73,7 @@ jobs:
7173
want=$(cargo tree $args -p aws-lc-rs 2>/dev/null | grep -oE "${crate} v[0-9]+(\.[0-9]+)+" | head -1 | sed 's/.* v//' || true)
7274
7375
echo "::error::Duplicate ${crate} in the ${label} build: Cargo.toml declares \"${have}\", aws-lc-rs pulls v${want}."
74-
echo "Why it matters: two versions compile two separate copies of AWS-LC -- roughly 2x the native build time and a larger binary for customers building our code."
76+
echo "Why it matters: two versions compile two separate copies of AWS-LC -- ~2x the native build time and a larger binary for customers building our code -- and it is unclear which version is actually in use, so our library's behavior can diverge if the two differ."
7577
echo "Fix: open a PR changing ${crate} in AwsEncryptionSDK/runtimes/rust/Cargo.toml from \"${have}\" to \"${want}\", then verify with: cargo tree -d${args:+ $args}"
7678
}
7779

0 commit comments

Comments
 (0)