Bump version to v3.5.0 (#437)

Author: axunonb

.github/workflows/SonarCloud.yml

@@ -17,8 +17,8 @@ jobs:
     # (PRs from forks can't access secrets other than secrets.GITHUB_TOKEN for security reasons)
     if: ${{ !github.event.pull_request.head.repo.fork }}
     env:
-      version: '3.4.0'
-      versionFile: '3.4.0'
+      version: '3.5.0'
+      versionFile: '3.5.0'
     steps:
       - name: Set up JDK 17
         uses: actions/setup-java@v4

appveyor.yml

@@ -27,7 +27,7 @@ for:
       - ps: dotnet restore SmartFormat.sln --verbosity quiet
       - ps: dotnet add .\SmartFormat.Tests\SmartFormat.Tests.csproj package AltCover
       - ps: |
-          $version = "3.4.0"
+          $version = "3.5.0"
           $versionFile = $version + "." + ${env:APPVEYOR_BUILD_NUMBER}
 
           if ($env:APPVEYOR_PULL_REQUEST_NUMBER) {

src/Directory.Build.props

@@ -8,8 +8,8 @@
         <Copyright>Copyright 2011-$(CurrentYear) SmartFormat Project</Copyright>
         <RepositoryUrl>https://github.com/axuno/SmartFormat.git</RepositoryUrl>
         <PublishRepositoryUrl>true</PublishRepositoryUrl>
-        <Version>3.4.0</Version>
-        <FileVersion>3.4.0</FileVersion>
+        <Version>3.5.0</Version>
+        <FileVersion>3.5.0</FileVersion>
         <AssemblyVersion>3.0.0</AssemblyVersion> <!--only update AssemblyVersion with major releases -->
         <LangVersion>latest</LangVersion>
         <EnableNETAnalyzers>true</EnableNETAnalyzers>

src/SmartFormat/Core/Parsing/Placeholder.cs

@@ -189,10 +189,10 @@ public string FormatterOptions
             if (_formatterOptionsCache != null) return _formatterOptionsCache;
             if (Length == 0) _formatterOptionsCache = string.Empty;
 
-            // The *default* max array length of ArrayPool<char>.Shared is 1,048,576.
+            // The *default* max array length of ArrayPool<char>.Shared is 1,048,576
+            // but renting more will still return the size we need.
             var pool = ArrayPool<char>.Shared;
             var resultBuffer = pool.Rent(Length);
-            System.Diagnostics.Debug.Assert(resultBuffer.Length >= Length, "ArrayPool buffer size is smaller than it should be");
 
             try
             {