Embeds when add links

[excid3]

One of the features I had copied from Basecamp into Trix was the "Embed" button that showed up when pasting into the link form. This is helpful for embedding YouTube videos, X posts, etc.

Is this something you're solving in the same way by adding to the link dialog or do you have new approach for this @jorgemanrubia?

[jorgemanrubia]

@excid3 we haven't designed this yet, but this is something we need to solve to use Lexxy in Basecamp. This is a question for our designers, but I'd love it if just pasting the embeddable link in a standlone line would insert the embed, or offer you an option to do it

On the editor internals' side, I'd love to have some kind of configurable system to "unfurlk links", that we could use for this and for other scenarios. E.g: if you paste an image link, you get the image; if you paste a tweet link, you get the Tweet embed; if you paste a link with an open-graph image, you get that; and that you could extend at wish (e.g: unfurl links to certain apps you want to support, such as Basecamp in our case).

CC @andyra @jzimdars @brian @flavorjones

[flavorjones]

I made a very rough draft attempt at "unfurling" links in #26 but it wasn't a clean change, wasn't a real embed, and wasn't using OpenGraph.

I want to call out one thing Jorge mentioned: we'd like the embed feature to include the ability to perform an "authenticated GET" (for a configurable set of domains) that is sent to the application server instead of the remote resource. Basically, the ability to say "send all embed requests for <DOMAIN> to <PATH>".

The use case for this feature is app suite integration. For example: if I'm in Fizzy and paste a link to a private Basecamp page, a simple GET will 401 or redirect. But I can build a controller in Fizzy that uses a shared secret to perform an authenticated GET behind the scenes, so I want Basecamp embed requests to be sent to that controller. (We might also want to be able to move that GET into a background job, so we may want the ability to respond async.)

I'm not sure I've explained this very well, LMK if I can clarify anything or if you have a cleverer solution for this use case.

[excid3]

Makes sense to me. For our use case, we want to use OEmbed to look up the URL and then return the embed. This allows us to validate and then choose which services we want to allow. Sounds like pretty much the same approach. 👍

[excid3]

@monorkin saw you added this! It works great.

One thing we don't have yet from Trix is the to_trix_content_attachment_partial_path. This is helpful for situations like embedding a YouTube video where you may want the thumbnail in the editor but the iframe in the rendered content.

Thoughts on adding something like that or taking a different approach?

[amo13]

Cool, but how do we embed a YouTube video now? Pasting the embed iframe code does not do anything and pasting the link to the video is just adding a link, not really embedding the video.