values removed when guideline calculated

[HeatherGranger]

This is a long-standing issue with calc_limits in wqbc. The selenium guideline is 2 ug/L and is not a calculated guideline based on a dependent parameter, so no values should be dropped. This may have to do with a 5 samples in 30 days criteria.

Dropped 31 values for Selenium Total without limits Calculated long-term water quality limits.

[aylapear]

Potentially tied to #135

[aylapear]

I will need a specific example of where this is happening as I am not getting this type of issue when I have tried a handful of sites and selected Selenium total as the variable. It throws issues when the short term or long term guideline is picked (which we have talked about trying to think of a more informative error message then what is displaying). It works when long-daily term is picked and plots a line on the graph. When I check the R console output I don't see any messages about it dropping values.

# long daily term
Converting Codes to Variables...
Replaced 'SE-T' with 'Selenium Total'.
Converted Codes to Variables.
Standardizing water quality data...
Standardized water quality data.
Calculating long-daily-term water quality limits...
O values without limits
Calculated long-daily-term water quality limits.

# long term
Converting Codes to Variables...
Replaced 'SE-T' with 'Selenium Total'.
Converted Codes to Variables.
Standardizing water quality data...
Standardized water quality data.
Calculating long-term water quality limits...

# short term
Converting Codes to Variables...
Replaced 'SE-T' with 'Selenium Total'.
Converted Codes to Variables.
Standardizing water quality data...
Standardized water quality data.
Calculating short-term water quality limits...

[aylapear]

I have noticed that when the variable is not present in the limits table that the error message displayed is helpful.

[HeatherGranger]

Try this Ayla, but I think we'll have to continue troubleshooting the aesthetic error.

links to #135

EMS ID: E206438, Selenium Total

error when I did the short term option (although I'm not sure this is related to the guideline piece)
�[38;5;255mCan't subset �[38;5;251m�[48;5;235m.data�[49m�[38;5;255m outside of a data mask context.�[39m

error when I did the long term daily option
Error in glubort(NULL, "x and y must share the same src, ", "set copy = TRUE (may be slow).") : x and y must share the same src, set copy = TRUE (may be slow).

error when I did the long term option
Warning: Error in check_aesthetics: Aesthetics must be either length 1 or the same as the data (105): colour
186:

error when I did the add manual option:
Warning: Error in check_aesthetics: Aesthetics must be either length 1 or the same as the data (4): colour
186: