Skip to content

Conversation

@curumore
Copy link
Contributor

@curumore curumore commented Jan 13, 2026

Fixes #1942

Adds a GPU support column to the supported providers table
to clearly indicate which providers support GPU nodes.

Summary by CodeRabbit

  • Documentation
    • Added a GPU column to the Supported Providers table with per-provider GPU indicators in the header and rows.
    • Updated each provider’s GPU status (supported, unsupported, or N/A) while preserving Node Pools, DNS, and DNS healthchecks information.
    • Clarified that "N/A" denotes non-applicable or untested GPU support and adjusted table formatting for alignment.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Walkthrough

Added a new "GPU" column to the Supported Providers table in README.md, populated per-provider GPU status indicators for AWS, Azure, GCP, OCI, Hetzner, Cloudflare, and OpenStack, adjusted table separators, and appended a note clarifying that N/A indicates non-applicable or untested GPU support.

Changes

Cohort / File(s) Summary
Documentation — providers table
README.md
Inserted a GPU column into the Supported Providers table, updated header separators and each provider row with GPU indicators (:heavy_check_mark:, :x:, N/A), and added a trailing note clarifying N/A.

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs: add GPU support column to supported providers table' accurately and clearly describes the main change in the PR.
Linked Issues check ✅ Passed The PR successfully implements all core objectives from issue #1942: adds GPU column, populates provider statuses with check/cross/N/A markers, and includes clarifying note about N/A.
Out of Scope Changes check ✅ Passed All changes are directly related to the GPU support column objective; only README.md was modified with +11/-9 lines focused on the table update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87cd20b and bfe753d.

📒 Files selected for processing (1)
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@samuelstolicny samuelstolicny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the GPU support column! I have a few questions about the testing methodology used for determining GPU support status.

I've tested Azure GPU support and it works correctly, but the PR marks it as :x: (not supported). Could you provide details on:

  1. Azure: What testing was done? I was able to get GPU nodes working on Azure, so I'd like to understand why it's marked as unsupported.

  2. OCI, OpenStack: Were these actually tested, or are they marked as :x: based on assumptions? It would be helpful to know:

    • Which specific instance types/configurations were tested
    • What errors or issues were encountered (if any)
    • Any logs or screenshots demonstrating the test results

Based on my testing:

  • Azure: ✅ Works (should be :heavy_check_mark:)
  • GCP: ❌ Confirmed not working
  • OCI: Untested
  • OpenStack: Untested

For untested providers, should we perhaps use a different indicator or add a footnote to clarify that some providers are "untested" rather than "confirmed not working"?

@samuelstolicny samuelstolicny added documentation Improvements or additions to documentation refresh-docs Trigger automatic update of the latest docs version. /refresh-docs comment is also a trigger. labels Jan 14, 2026
@curumore
Copy link
Contributor Author

Thanks for the clarification and for testing Azure GPU support.

You’re right, the initial ❌ markings were not based on hands-on testing across all providers, which makes them misleading.

I’ve updated the table to:

Mark Azure as ✔️ based on your confirmation

Keep GCP as ❌ (tested and confirmed not working)

Mark OCI and OpenStack as N/A to indicate it has not been tested

Add a general footnote explaining that N/A means the feature is either not applicable for the provider or has not been tested yet, to avoid ambiguity across the table

Please let me know if this representation looks good to you.

@curumore
Copy link
Contributor Author

Thanks for testing and for the suggested update! I’ve committed the changes.

@curumore
Copy link
Contributor Author

Added Hetzner GPU support as suggested. Thanks for the clarification regarding static node pools.

@samuelstolicny
Copy link
Contributor

Hi @curumore ! I just merged a fix for the CI pipeline in #1944 that fixes issues with fork PRs.
​To get the CI builds passing on this PR, you will need to rebase your forked branch onto the latest master branch from the upstream repository (berops/claudie). This will pull in the CI pipeline fixes that allow the workflow to run properly for PRs from forks. After that we can finally merge this PR.

@curumore curumore force-pushed the issue;1942-add-gpu-support-column branch from 0fc98c0 to 87cd20b Compare January 16, 2026 12:51
@curumore
Copy link
Contributor Author

Thanks for the CI fix! I’ve rebased the branch onto the latest upstream master and re-applied the suggested changes. CI should be running correctly now.

@samuelstolicny samuelstolicny dismissed their stale review January 19, 2026 07:50

Requested changes were implemented

Copy link
Contributor

@samuelstolicny samuelstolicny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @curumore for your contribution

@samuelstolicny samuelstolicny added this pull request to the merge queue Jan 19, 2026
Merged via the queue into berops:master with commit ce3da41 Jan 19, 2026
7 checks passed
@curumore curumore deleted the issue;1942-add-gpu-support-column branch January 22, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation refresh-docs Trigger automatic update of the latest docs version. /refresh-docs comment is also a trigger.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Add GPU support column to supported providers table

2 participants