-
Notifications
You must be signed in to change notification settings - Fork 52
docs: add GPU support column to supported providers table #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add GPU support column to supported providers table #1943
Conversation
WalkthroughAdded a new "GPU" column to the Supported Providers table in Changes
Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
samuelstolicny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the GPU support column! I have a few questions about the testing methodology used for determining GPU support status.
I've tested Azure GPU support and it works correctly, but the PR marks it as :x: (not supported). Could you provide details on:
-
Azure: What testing was done? I was able to get GPU nodes working on Azure, so I'd like to understand why it's marked as unsupported.
-
OCI, OpenStack: Were these actually tested, or are they marked as
:x:based on assumptions? It would be helpful to know:- Which specific instance types/configurations were tested
- What errors or issues were encountered (if any)
- Any logs or screenshots demonstrating the test results
Based on my testing:
- Azure: ✅ Works (should be
:heavy_check_mark:) - GCP: ❌ Confirmed not working
- OCI: Untested
- OpenStack: Untested
For untested providers, should we perhaps use a different indicator or add a footnote to clarify that some providers are "untested" rather than "confirmed not working"?
|
Thanks for the clarification and for testing Azure GPU support. You’re right, the initial ❌ markings were not based on hands-on testing across all providers, which makes them misleading. I’ve updated the table to: Mark Azure as ✔️ based on your confirmation Keep GCP as ❌ (tested and confirmed not working) Mark OCI and OpenStack as N/A to indicate it has not been tested Add a general footnote explaining that N/A means the feature is either not applicable for the provider or has not been tested yet, to avoid ambiguity across the table Please let me know if this representation looks good to you. |
|
Thanks for testing and for the suggested update! I’ve committed the changes. |
|
Added Hetzner GPU support as suggested. Thanks for the clarification regarding static node pools. |
|
Hi @curumore ! I just merged a fix for the CI pipeline in #1944 that fixes issues with fork PRs. |
0fc98c0 to
87cd20b
Compare
|
Thanks for the CI fix! I’ve rebased the branch onto the latest upstream master and re-applied the suggested changes. CI should be running correctly now. |
Requested changes were implemented
samuelstolicny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @curumore for your contribution
Fixes #1942
Adds a GPU support column to the supported providers table
to clearly indicate which providers support GPU nodes.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.