Skip to content

Commit 2b9df94

Browse files
committed
fix: Fix for #282
While custom `persistentVolumeClaim`s where being implemented, the one without a custom claim were gone missing. This was now re-added.
1 parent 9babe64 commit 2b9df94

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

helm/mail/templates/statefulset.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,12 @@ spec:
206206
{{- if and .Values.persistence.enabled .Values.persistence.existingClaim }}
207207
- name: {{ $fullName }}
208208
persistentVolumeClaim:
209-
{{- with .Values.persistence.existingClaim }}
209+
{{- if .Values.persistence.existingClaim -}}{{- with .Values.persistence.existingClaim }}
210210
claimName: {{ tpl . $ }}
211211
{{- end }}
212+
{{- else }}
213+
claimName: {{ $fullName }}
214+
{{- end }}
212215
{{- else if not .Values.persistence.enabled }}
213216
- name: {{ $fullName }}
214217
emptyDir: {}

helm/tests.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ do_the_test() {
3535
local i="${1}" v
3636
printf '%s' "${gray}☆☆☆☆☆☆☆☆☆☆${reset} ${orange_emphasis}$i${reset}: ${gray}☆☆☆☆☆☆☆☆☆☆${reset}"
3737
echo
38-
for v in 1.22.9 1.29.4 1.32.10 1.33.6 1.34.2; do
38+
# Test only non-EOL versions
39+
for v in 1.33.13 1.34.9 1.36.2; do
3940
printf '%s' "${emphasis}${lightblue}k8s v${v}${reset}${lightblue}... ${reset}"
4041
helm template -f "${i}" --kube-version "${v}" --dry-run=client mail > fixtures/demo.yaml
4142
${DOCKER} run \

0 commit comments

Comments
 (0)