fix(tests): fix storage configuration

Author: papac

.github/workflows/tests.yml

@@ -59,6 +59,11 @@ jobs:
             sleep 2
           done
 
+      - name: Wait for MinIO bucket initialization
+        run: |
+          echo "Waiting for MinIO bucket initialization..."
+          docker wait bowphp_minio_init || true
+
       - name: Cache Composer packages
         id: composer-cache
         uses: actions/cache@v4

tests/Config/stubs/config/storage.php

@@ -39,15 +39,17 @@
         's3' => [
             "driver" => "s3",
             'credentials' => [
-                'key' => app_env('AWS_KEY', 'minioadmin'),
-                'secret' => app_env('AWS_SECRET', 'minioadmin'),
+                // `?:` so an unset env (which CI exposes as an empty string)
+                // falls back to the local docker-compose MinIO defaults.
+                'key' => app_env('AWS_KEY') ?: 'minioadmin',
+                'secret' => app_env('AWS_SECRET') ?: 'minioadmin',
             ],
-            'bucket' => app_env('AWS_S3_BUCKET', 'tests'),
-            'region' => app_env('AWS_REGION', 'us-east-1'),
+            'bucket' => app_env('AWS_S3_BUCKET') ?: 'tests',
+            'region' => app_env('AWS_REGION') ?: 'us-east-1',
             'version' => 'latest',
             // MinIO configuration. Defaults target the local docker-compose
             // MinIO service; override via env for a real AWS S3 endpoint.
-            'endpoint' => app_env('AWS_ENDPOINT', 'http://127.0.0.1:9000'),
+            'endpoint' => app_env('AWS_ENDPOINT') ?: 'http://127.0.0.1:9000',
             'use_path_style_endpoint' => true, // Set to true for MinIO
         ]
     ],

tests/Routing/AttributeRouteIntegrationTest.php

@@ -41,8 +41,14 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        // Reset the router for each test
         $this->router = Router::configure();
+
+        // The route collection is a global (static) registry that intentionally
+        // gathers routes across every Router instance. Clear it before each test
+        // so assertions are not polluted by routes registered by earlier tests.
+        $routes = new \ReflectionProperty(Router::class, 'routes');
+        $routes->setAccessible(true);
+        $routes->setValue(null, []);
     }
 
     public function test_registrar_registers_routes_from_controller(): void