Commit 2bdfc9d
authored
feat(lsi): add hash-style API for adding items (#101)
* test: add property-based tests for probabilistic invariants
Add comprehensive property-based testing using the Rantly gem to verify
that probabilistic invariants hold across random inputs. This addresses
the gap in test coverage for edge cases and mathematical properties.
Tests added for Bayes classifier:
- Classification determinism (same input = same output)
- Training order independence (commutativity)
- Train/untrain inverse property
- Word and category counts never go negative
- Log probabilities are always finite
- Multiple training equivalence
Tests added for LSI:
- Classification, search, and find_related determinism
- Graceful handling of uncategorized items
- Consistency after index rebuild
Tests added for category operations:
- Add/remove category consistency
- Training data isolation between categories
Closes #70
* style: fix RuboCop offenses in property tests
* refactor: remove redundant comments from property tests
* ci: drop Ruby 3.2 from test matrix
* feat(lsi): add hash-style API for adding items
The existing add_item API had confusing positional arguments - it wasn't
clear whether the first argument was the key or the content. The new
add() method uses hash syntax to make the relationship explicit:
lsi.add("Ruby programming" => doc1)
lsi.add("Java development" => [doc2, :programming])
This also enables batch operations naturally:
lsi.add(
"Ruby programming" => doc1,
"Java development" => doc2
)
The add_item method is preserved but marked as deprecated for backward
compatibility.
Closes #100
* style: fix RuboCop symbol array offenses
* fix(lsi): correct add API to use category => items syntax
The hash key should be the category, with values being items (or arrays
of items) that belong to that category. This mirrors the Bayes API:
lsi.add("Dog" => "Dogs are loyal pets")
lsi.add("Dog" => ["Puppies are cute", "Canines are friendly"])
lsi.add(
"Dog" => ["Dogs are loyal", "Puppies are cute"],
"Cat" => ["Cats are independent", "Kittens are playful"]
)
* refactor(lsi): simplify add method with Array()1 parent 7d70749 commit 2bdfc9d
3 files changed
+146
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
123 | 131 | | |
124 | 132 | | |
125 | 133 | | |
126 | | - | |
| 134 | + | |
127 | 135 | | |
128 | 136 | | |
129 | 137 | | |
130 | | - | |
| 138 | + | |
131 | 139 | | |
132 | 140 | | |
133 | 141 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
125 | 150 | | |
126 | 151 | | |
127 | 152 | | |
128 | 153 | | |
129 | 154 | | |
130 | 155 | | |
| 156 | + | |
| 157 | + | |
131 | 158 | | |
132 | 159 | | |
133 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
14 | 118 | | |
15 | 119 | | |
16 | 120 | | |
| |||
0 commit comments