Skip to content

Commit d32f620

Browse files
committed
TA-4551: Change method naming mistake to represent package instead of node
1 parent 0992c57 commit d32f620

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/commands/configuration-management/package-version-command.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ export class PackageVersionCommandService {
1010
}
1111

1212
public async getPackageVersion(packageKey: string, version: string, jsonResponse: boolean): Promise<void> {
13-
await this.packageVersionService.findNode(packageKey, version, jsonResponse);
13+
await this.packageVersionService.findPackageVersion(packageKey, version, jsonResponse);
1414
}
1515
}

src/commands/configuration-management/package-version.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export class PackageVersionService {
1212
this.packageVersionApi = new PackageVersionApi(context);
1313
}
1414

15-
public async findNode(packageKey: string, version: string, jsonResponse: boolean): Promise<void> {
15+
public async findPackageVersion(packageKey: string, version: string, jsonResponse: boolean): Promise<void> {
1616
const packageVersionTransport: PackageVersionTransport = await this.packageVersionApi.findOne(packageKey, version);
1717
if (jsonResponse) {
1818
const filename = uuidv4() + ".json";

tests/commands/configuration-management/config-version-metadata.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe("Package Version get", () => {
2323
const version = "1.2.3";
2424
mockAxiosGet(`https://myTeam.celonis.cloud/pacman/api/core/packages/${packageKey}/versions/${version}`, packageVersion);
2525

26-
await new PackageVersionService(testContext).findNode(packageKey, version, false);
26+
await new PackageVersionService(testContext).findPackageVersion(packageKey, version, false);
2727

2828
expect(loggingTestTransport.logMessages.length).toBe(8);
2929
expect(loggingTestTransport.logMessages[0].message).toContain(`Package Key: ${packageVersion.packageKey}`);
@@ -41,7 +41,7 @@ describe("Package Version get", () => {
4141
const version = "1.2.3";
4242
mockAxiosGet(`https://myTeam.celonis.cloud/pacman/api/core/packages/${packageKey}/versions/${version}`, packageVersion);
4343

44-
await new PackageVersionService(testContext).findNode(packageKey, version, true);
44+
await new PackageVersionService(testContext).findPackageVersion(packageKey, version, true);
4545

4646
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
4747

@@ -64,7 +64,7 @@ describe("Package Version get", () => {
6464

6565
mockAxiosGet(`https://myTeam.celonis.cloud/pacman/api/core/packages/${packageKey}/versions/${version}`, packageVersionWithEmptyMessage);
6666

67-
await new PackageVersionService(testContext).findNode(packageKey, version, false);
67+
await new PackageVersionService(testContext).findPackageVersion(packageKey, version, false);
6868

6969
expect(loggingTestTransport.logMessages.length).toBe(8);
7070
expect(loggingTestTransport.logMessages[5].message).toContain("Publish Message: ");

0 commit comments

Comments
 (0)