[rgw] Why are some parameters unsupported ?

[Alysty]

I found this comment // valid parameters not supported by go-ceph: system, exclusive, placement-tags in the Create user function and I was wondering if there is a specific reason why its not supported. is there an issue with just adding it to the struct and to the array in the function ?

func (api *API) CreateUser(ctx context.Context, user User) (User, error) {
	if user.ID == "" {
		return User{}, errMissingUserID
	}
	if user.DisplayName == "" {
		return User{}, errMissingUserDisplayName
	}

	// valid parameters not supported by go-ceph: system, exclusive, placement-tags
	body, err := api.call(ctx, http.MethodPut, "/user", valueToURLParams(user, []string{"uid", "display-name", "default-placement", "email", "key-type", "access-key", "secret-key", "user-caps", "tenant", "generate-key", "max-buckets", "suspended", "op-mask", "account-id", "account-root"}))
	if err != nil {
		return User{}, err
	}

	// Unmarshal response into Go type
	u := User{}
	err = json.Unmarshal(body, &u)
	if err != nil {
		return User{}, fmt.Errorf("%s. %s. %w", unmarshalError, string(body), err)
	}

	return u, nil
}

[phlogistonjohn]

cc: @anoopcs9 @thotz

[nixpanic]

This seems to originate from commit 1de6083 . Newer versions of Ceph RGW may have added support for more parameters. Similar to default-placement, which was added at a later point with commit 1cfede9.

[Alysty]

so these parameters are not available in the ceph api ? from the wording of the comment I thought they were and just the unavailable in ceph-go

[nixpanic]

I think Ceph RGW does not support them. The documentation of the most recent Ceph release does not list system, exclusive or placement-tags.

@thotz definitely has more knowledge about it than I do, so let's wait for his response.