[JOSS] Plaintext credential cache

[schochastics]

bs_cache_auth <- function(user, pass, host = get_bluesky_pds()) {
  fs::dir_create(fs::path_dir(bs_auth_file()))
  if (fs::file_exists(bs_auth_file())) {
    # if (bs_has_user()) {
    #   auth <- httr2::secret_read_rds(bs_auth_file(), key = 'BLUESKY_APP_USER')
    # } else {
    auth <- readRDS(bs_auth_file())
    # }
    if (bs_auth_is_valid(auth)) {
      return(auth)
    }
  }

  auth <- bs_create_auth(user, pass, host)
  # if (bs_has_user()) {
  #   httr2::secret_write_rds(auth, path = bs_auth_file(), key = 'BLUESKY_APP_USER')
  # } else {
  saveRDS(auth, bs_auth_file())
  # }
  auth
}

looks like encryption was considered but is not in use anymore. Writing plaintext auth to a file is not a good idea

[christopherkenny]

Thank you, as this is a very helpful catch. As you note, I originally intended for this to be encrypted, but never finished figuring out the correct workflow. I have now implemented this using httr2's secret RDS features.