Skip to content

Commit f8e914e

Browse files
committed
Some improvement of ws client #131
1 parent c90c077 commit f8e914e

11 files changed

Lines changed: 13 additions & 11 deletions

File tree

examples/WsChatClient/Program.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ public override void OnWsConnecting(HttpRequest request)
2828
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2929
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
3030
request.SetHeader("Sec-WebSocket-Version", "13");
31+
request.SetBody();
3132
}
3233

3334
public override void OnWsConnected(HttpResponse response)

examples/WssChatClient/Program.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public override void OnWsConnecting(HttpRequest request)
3030
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
3131
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
3232
request.SetHeader("Sec-WebSocket-Version", "13");
33+
request.SetBody();
3334
}
3435

3536
public override void OnWsConnected(HttpResponse response)

performance/WsEchoClient/Program.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ public override void OnWsConnecting(HttpRequest request)
2525
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2626
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
2727
request.SetHeader("Sec-WebSocket-Version", "13");
28+
request.SetBody();
2829
}
2930

3031
public override void OnWsConnected(HttpResponse response)

performance/WsMulticastClient/Program.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public override void OnWsConnecting(HttpRequest request)
2424
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2525
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
2626
request.SetHeader("Sec-WebSocket-Version", "13");
27+
request.SetBody();
2728
}
2829

2930
public override void OnWsReceived(byte[] buffer, long offset, long size)

performance/WssEchoClient/Program.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public override void OnWsConnecting(HttpRequest request)
2727
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2828
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
2929
request.SetHeader("Sec-WebSocket-Version", "13");
30+
request.SetBody();
3031
}
3132

3233
public override void OnWsConnected(HttpResponse response)

performance/WssMulticastClient/Program.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public override void OnWsConnecting(HttpRequest request)
2626
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
2727
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
2828
request.SetHeader("Sec-WebSocket-Version", "13");
29+
request.SetBody();
2930
}
3031

3132
public override void OnWsReceived(byte[] buffer, long offset, long size)

source/NetCoreServer/NetCoreServer.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFramework>net5.0</TargetFramework>
5-
<Version>5.0.15.0</Version>
5+
<Version>5.0.16.0</Version>
66
<Authors>Ivan Shynkarenka</Authors>
77
<Copyright>Copyright (c) 2019-2021 Ivan Shynkarenka</Copyright>
88
<RepositoryUrl>https://github.com/chronoxor/NetCoreServer</RepositoryUrl>

source/NetCoreServer/WsClient.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -320,14 +320,11 @@ protected override void OnConnected()
320320
// Fill the WebSocket upgrade HTTP request
321321
OnWsConnecting(Request);
322322

323-
// Set empty body of the WebSocket upgrade HTTP request
324-
Request.SetBody();
325-
326323
// Send the WebSocket upgrade HTTP request
327324
if (_syncConnect)
328-
Send(Request.Cache.Data);
325+
SendRequest(Request);
329326
else
330-
SendAsync(Request.Cache.Data);
327+
SendRequestAsync(Request);
331328
}
332329

333330
protected override void OnDisconnecting()

source/NetCoreServer/WssClient.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -323,14 +323,11 @@ protected override void OnHandshaked()
323323
// Fill the WebSocket upgrade HTTP request
324324
OnWsConnecting(Request);
325325

326-
// Set empty body of the WebSocket upgrade HTTP request
327-
Request.SetBody();
328-
329326
// Send the WebSocket upgrade HTTP request
330327
if (_syncConnect)
331-
Send(Request.Cache.Data);
328+
SendRequest(Request);
332329
else
333-
SendAsync(Request.Cache.Data);
330+
SendRequestAsync(Request);
334331
}
335332

336333
protected override void OnDisconnecting()

tests/WsTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ public override void OnWsConnecting(HttpRequest request)
2929
request.SetHeader("Sec-WebSocket-Key", Convert.ToBase64String(WsNonce));
3030
request.SetHeader("Sec-WebSocket-Protocol", "chat, superchat");
3131
request.SetHeader("Sec-WebSocket-Version", "13");
32+
request.SetBody();
3233
}
3334
public override void OnWsConnected(HttpResponse response) { IsWsConnected = true; Connected = true; }
3435
public override void OnWsDisconnected() { IsWsConnected = false; Disconnected = true; }

0 commit comments

Comments
 (0)