Skip to content

Commit bc247a8

Browse files
author
jsf9k
committed
Merge https://github.com/cisagov/skeleton-packer into lineage/skeleton
# Conflicts: # version.txt
2 parents 595f3f3 + 4e8001c commit bc247a8

11 files changed

Lines changed: 67 additions & 93 deletions

File tree

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108
permissions_monitoring_config: ${{ vars.ACTIONS_PERMISSIONS_CONFIG }}
109109
- id: setup-env
110110
uses: cisagov/setup-env-github-action@v1
111-
- uses: actions/checkout@v5
111+
- uses: actions/checkout@v6
112112
- id: setup-python
113113
uses: actions/setup-python@v6
114114
with:
@@ -246,7 +246,7 @@ jobs:
246246
permissions_monitoring_config: ${{ vars.ACTIONS_PERMISSIONS_CONFIG }}
247247
- id: setup-env
248248
uses: cisagov/setup-env-github-action@v1
249-
- uses: actions/checkout@v5
249+
- uses: actions/checkout@v6
250250
- id: setup-python
251251
uses: actions/setup-python@v6
252252
with:
@@ -324,7 +324,7 @@ jobs:
324324
permissions_monitoring_config: ${{ vars.ACTIONS_PERMISSIONS_CONFIG }}
325325
- id: setup-env
326326
uses: cisagov/setup-env-github-action@v1
327-
- uses: actions/checkout@v5
327+
- uses: actions/checkout@v6
328328
- id: setup-python
329329
uses: actions/setup-python@v6
330330
with:

.github/workflows/codeql-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ jobs:
113113
permissions_monitoring_config: ${{ vars.ACTIONS_PERMISSIONS_CONFIG }}
114114

115115
- name: Checkout repository
116-
uses: actions/checkout@v5
116+
uses: actions/checkout@v6
117117

118118
# Initializes the CodeQL tools for scanning.
119119
- name: Initialize CodeQL

.github/workflows/dependency-review.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
permissions_monitoring_config: ${{ vars.ACTIONS_PERMISSIONS_CONFIG }}
9090
- id: checkout-repo
9191
name: Checkout the repository
92-
uses: actions/checkout@v5
92+
uses: actions/checkout@v6
9393
- id: dependency-review
9494
name: Review dependency changes for vulnerabilities and license changes
9595
uses: actions/dependency-review-action@v4

.github/workflows/prerelease.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
permissions_monitoring_config: ${{ vars.ACTIONS_PERMISSIONS_CONFIG }}
9999
- id: setup-env
100100
uses: cisagov/setup-env-github-action@v1
101-
- uses: actions/checkout@v5
101+
- uses: actions/checkout@v6
102102
- id: setup-python
103103
uses: actions/setup-python@v6
104104
with:

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ jobs:
105105
permissions_monitoring_config: ${{ vars.ACTIONS_PERMISSIONS_CONFIG }}
106106
- id: setup-env
107107
uses: cisagov/setup-env-github-action@v1
108-
- uses: actions/checkout@v5
108+
- uses: actions/checkout@v6
109109
- id: setup-python
110110
uses: actions/setup-python@v6
111111
with:

.github/workflows/sync-labels.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484
# monitoring configuration *does not* require you to modify
8585
# this workflow.
8686
permissions_monitoring_config: ${{ vars.ACTIONS_PERMISSIONS_CONFIG }}
87-
- uses: actions/checkout@v5
87+
- uses: actions/checkout@v6
8888
- name: Sync repository labels
8989
if: success()
9090
uses: crazy-max/ghaction-github-labeler@v5

.pre-commit-config.yaml

Lines changed: 21 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -167,11 +167,19 @@ repos:
167167
hooks:
168168
- id: pip-audit
169169
args:
170-
# We have to ignore this particular vulnerability in
171-
# ansible-core>=2.11 as there is currently no fix. See
172-
# cisagov/skeleton-packer#380 for more details.
170+
# We have to ignore this vulnerability since we need to pin
171+
# to ansible 10 for now to support our CyHy code that must
172+
# still run on Debian Buster. This vulnerability is fixed
173+
# in ansible>=12.
174+
#
175+
# This isn't a big deal since the vulnerability only impacts
176+
# users of the Keycloak modules in
177+
# ansible.community.general, and we don't use these modules.
178+
#
179+
# TODO: Remove this when it becomes possible. See
180+
# cisagov/skeleton-packer#486 for more details.
173181
- --ignore-vuln
174-
- GHSA-99w6-3xph-cx78
182+
- GHSA-8ggh-xwr9-3373
175183
# Add any pip requirements files to scan
176184
- --requirement
177185
- requirements-dev.txt
@@ -183,10 +191,16 @@ repos:
183191
rev: v3.21.1
184192
hooks:
185193
- id: pyupgrade
194+
args:
195+
# Python 3.10 is currently the oldest non-EOL version of
196+
# Python, so we want to apply all rules that apply to this
197+
# version or later. See here for more details:
198+
# https://www.gyford.com/phil/writing/2025/08/26/how-to-use-pyupgrade/
199+
- --py310-plus
186200

187201
# Ansible hooks
188202
- repo: https://github.com/ansible/ansible-lint
189-
rev: v25.11.0
203+
rev: v25.11.1
190204
hooks:
191205
- id: ansible-lint
192206
additional_dependencies:
@@ -202,31 +216,13 @@ repos:
202216
# hook identifies a vulnerability in ansible-core 2.16.13,
203217
# but all versions of ansible 9 have a dependency on
204218
# ~=2.16.X.
205-
#
206-
# It is also a good idea to go ahead and upgrade to version
207-
# 10 since version 9 is going EOL at the end of November:
208-
# https://endoflife.date/ansible
209219
# - ansible>=10,<11
210-
# ansible-core 2.16.3 through 2.16.6 suffer from the bug
211-
# discussed in ansible/ansible#82702, which breaks any
212-
# symlinked files in vars, tasks, etc. for any Ansible role
213-
# installed via ansible-galaxy. Hence we never want to
214-
# install those versions.
215-
#
216-
# Note that the pip-audit pre-commit hook identifies a
217-
# vulnerability in ansible-core 2.16.13. The pin of
218-
# ansible-core to >=2.17 effectively also pins ansible to
219-
# >=10.
220-
#
221-
# It is also a good idea to go ahead and upgrade to
222-
# ansible-core 2.17 since security support for ansible-core
223-
# 2.16 ends this month:
224-
# https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix
220+
# ansible-core<2.17.7 suffers from GHSA-99w6-3xph-cx78.
225221
#
226222
# Note that any changes made to this dependency must also be
227223
# made in requirements.txt in cisagov/skeleton-packer and
228224
# requirements-test.txt in cisagov/skeleton-ansible-role.
229-
- ansible-core>=2.17
225+
- ansible-core>=2.17.7
230226

231227
# Terraform hooks
232228
- repo: https://github.com/antonbabenko/pre-commit-terraform

requirements.txt

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,18 @@
1-
# With the release of version 2.10, Ansible finally correctly
2-
# identifies Kali Linux as being the Kali distribution of the Debian
3-
# OS family. This simplifies a lot of things for roles that support
4-
# Kali Linux, so it makes sense to force the installation of Ansible
5-
# 2.10 or newer.
6-
#
7-
# We need at least version 6 to correctly identify Amazon Linux 2023
8-
# as using the dnf package manager, and version 8 is currently the
9-
# oldest supported version.
10-
#
111
# Version 10 is required because the pip-audit pre-commit hook
122
# identifies a vulnerability in ansible-core 2.16.13, but all versions
133
# of ansible 9 have a dependency on ~=2.16.X.
144
#
15-
# It is also a good idea to go ahead and upgrade to version 10 since
16-
# version 9 is going EOL at the end of November:
17-
# https://endoflife.date/ansible
18-
#
195
# We have tested against version 10. We want to avoid automatically
206
# jumping to another major version without testing, since there are
217
# often breaking changes across major versions. This is the reason
228
# for the upper bound.
239
ansible>=10,<11
24-
# ansible-core 2.16.3 through 2.16.6 suffer from the bug discussed in
25-
# ansible/ansible#82702, which breaks any symlinked files in vars,
26-
# tasks, etc. for any Ansible role installed via ansible-galaxy.
27-
# Hence we never want to install those versions.
28-
#
29-
# Note that the pip-audit pre-commit hook identifies a vulnerability
30-
# in ansible-core 2.16.13. Normally we would pin ansible-core
31-
# accordingly (>2.16.13), but the above pin of ansible>=10 effectively
32-
# pins ansible-core to >=2.17 anyway so that's what we use.
33-
#
34-
# It is also a good idea to go ahead and upgrade to ansible-core 2.17
35-
# since security support for ansible-core 2.16 ends this month:
36-
# https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix
10+
# ansible-core<2.17.7 suffers from GHSA-99w6-3xph-cx78.
3711
#
3812
# Note that any changes made to this dependency must also be made in
3913
# requirements-test.txt in cisagov/skeleton-ansible-role and
4014
# .pre-commit-config.yaml in cisagov/skeleton-generic.
41-
ansible-core>=2.17
15+
ansible-core>=2.17.7
4216
boto3
4317
docopt
4418
# The bump-version script requires at least version 3 of semver.

terraform-build-user/.terraform.lock.hcl

Lines changed: 16 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

terraform-post-packer/.terraform.lock.hcl

Lines changed: 16 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)