CEventNetworkEntityDamage inconsistency.

[Randolio]

What happened?

Having an issue related to the handler 'gameEventTriggered' triggering CEventNetworkEntityDamage. On build 3717 with artifacts 26261, taking damage and not dying does not seem to fire CEventNetworkEntityDamage. I tried dropping to a lower artifacts version and same result. However, testing on 3570 with artifacts 26261 it works perfectly fine. On both 3717 and 3570, dying triggers the event fine. On 3717, I can shoot a vehicle once and the event fires fine.

3717:
https://github.com/user-attachments/assets/d654f9c5-23c5-43da-a0f6-8667b027945d

3570:
https://github.com/user-attachments/assets/f0cb076c-c48b-42ce-8dca-6dbd236acd24

Expected result

I expect the event to fire when an entity takes damage.

Reproduction steps

1. Jump off a roof in game
2. Listen for event print

Importancy

Slight inconvenience

Area(s)

FiveM

Specific version(s)

3717

Additional information

I also tested 3751 and it acts the same as 3717.

[Gogsi]

From my testing this might be specific to fall damage:

Here's my reproduction script, then I just noclip in the air and fall down to take fall damage

function integerBitsToFloat(integerValue)
    local bytes = string.pack('I4', integerValue)
    local floatValue, _ = string.unpack('f', bytes)
    return floatValue
end


AddEventHandler('gameEventTriggered', function (name, args)
  print('game event ' .. name .. ' (' .. json.encode(args) .. ')')

   if name ~= 'CEventNetworkEntityDamage' then return end

    local victim = args[1]
    local damager = args[2]
    local damage = args[3]
    local damageConverted = integerBitsToFloat(damage) -- Some values have to be converted into proper floats.
    local enduranceDamage = args[4]
    local enduranceDamageConverted = integerBitsToFloat(enduranceDamage)
    local victimIncapacitated = args[5] == 1
    local victimKilled = args[6] == 1
    local weaponUsed = args[7]
    local victimSpeed = args[8]
    local victimSpeedConverted = integerBitsToFloat(victimSpeed)
    local damagerSpeed = args[9]
    local damagerSpeedConverted = integerBitsToFloat(damagerSpeed)
    local isResponsibleForCollision = args[10] == 1 -- Is vehicle responsible for the collision
    local isHeadshot = args[11] == 1
    local withMeleeWeapon = args[12] == 1
    local hitMaterial = args[13] -- returns indices from materials.dat

    print(string.format("Victim: %d, Damager: %d, Damage: %f, EnduranceDamage: %f, VictimIncapacitated: %s, VictimKilled: %s, WeaponUsed: %d, VictimSpeed: %f, DamagerSpeed: %f, IsResponsibleForCollision: %s, IsHeadshot: %s, WithMeleeWeapon: %s, HitMaterial: %d",
        victim,
        damager,
        damageConverted,
        enduranceDamageConverted,
        tostring(victimIncapacitated),
        tostring(victimKilled),
        weaponUsed,
        victimSpeedConverted,
        damagerSpeedConverted,
        tostring(isResponsibleForCollision),
        tostring(isHeadshot),
        tostring(withMeleeWeapon),
        hitMaterial
    ))
end)

I took fall damage while full HP and the CEventNetworkEntityDamage didn't trigger:

Here I took damage from a molotov, cleared the console of the molotov logs, and then took subsequent fall damage. The CEventNetworkEntityDamage triggered but with the weapon hash of the molotov (615608432):

Seems that the game doesn't consider fall damage to trigger the event unless you've already taken damage from a weapon, very weird.

[tens0rfl0w]

@Gogsi The patch in here broke due to changed vtable indices (again)