Skip to content

Warnings on member initialisation order in NMEAParser and NMEASentence #20

@jmccabe

Description

@jmccabe

NMEASentence and NMEAParser constructors cause warnings on member variable initialisation order; I suggest changing from:

NMEASentence::NMEASentence() 
: isvalid(false)
, checksumIsCalculated(false)
, calculatedChecksum(0)
, parsedChecksum(0)
{ }

to

NMEASentence::NMEASentence() 
: isvalid(false)
, checksumIsCalculated(false)
, parsedChecksum(0)
, calculatedChecksum(0)
{ }

and from

NMEAParser::NMEAParser() 
: log(false)
, maxbuffersize(NMEA_PARSER_MAX_BUFFER_SIZE)
, fillingbuffer(false)
{ }

to

NMEAParser::NMEAParser()
: fillingbuffer(false)
, maxbuffersize(NMEA_PARSER_MAX_BUFFER_SIZE)
, log(false)
{ }

or use non-static member initialisation where they're declared.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions