NumLock makes buttons false reporting as pressed

[MiranDMC]

Clicking NumLock button while any numpad key is hold down causes all key related commands to report it as down, even after release.
Test script:

{$CLEO}
nop

while true
    wait 0
    
    int a = false
    if
        is_key_pressed {keyCode} KeyCode.NumPad8
    then
        a = true
    end
    
    int b = false
    if
        is_key_pressed {keyCode} KeyCode.Up
    then
        b = true
    end
    
    print_formatted_now {format} "Num8: %d~n~Up: %d" {time} 50 {args} a b
end

This seems to be known problem of GetKeyState API, without good solution.

[MiranDMC]

Solution might be to hook KeyboardHandler at 0x744880 and use it to update key states info instead using GetKeyboardState.
Anything else inside game logic is already converted from virtual key codes to something else.

[x87]

Sounds like a feature, not a bug

[MiranDMC]

Not really:

• disable numlock
• press and hold num 8
• press numlock key
• release num 8

Now CLEO will be reporting the up arrow key as holded down, even despite the player is not walking forward.

[x87]

Up arrow of 8 num key?

[MiranDMC]

NumLock button switches functionality of num keys, turning them into arrow keys equivalent.
The bug can be done for both of the key set, as the moment NumLock state is switched releasing the key sends UP code for the new state. So key remains "down" as release command was never send.
Just use example script to replicate the problem.

[x87]

I mean, yes, and what? It seems like intentional behavior of NumLock

Num Lock (short for Number Lock) is a key on the keyboard that toggles the numeric keypad between two modes: numeric entry and navigation. When Num Lock is enabled, the keys on the numeric keypad input numbers; when disabled, they perform navigation functions like arrow keys.

[x87]

Regarding the stuck key, it is Windows reporting the key as being held after NumLock switch, not us. I don't think we should bother. Consider this as a hidden macro.
Similar as some keyboards let you reprogram the keys to emulate the "Up" without touching the physical button.

[MiranDMC]

It renders all num keys unusable in scripts, as at any point user can by mistake click NumLock and make script not behaving as expected. It can also affect arrow and page up/down keys.
I had same problem myself but I blamed it as hardware issue then recently it happened to script user, in the wild, wasting good amount of time on troubleshooting.

This "macro" is not seen by the game, or any other application I tried. Replicating same scenario in Notepad does not keep typing "8" when key is not hold down.