Refactor test names to start lowercase

micaelgallego · micaelgallego · commit ec440bcbb690 · 2020-11-11T23:36:14.000+01:00
diff --git a/tema1_2_ejer3/src/test/java/es/codeurjc/test/complex/ComplexTest.java b/tema1_2_ejer3/src/test/java/es/codeurjc/test/complex/ComplexTest.java
@@ -15,19 +15,19 @@ public void setUp() {
 	}
 
 	@Test
-	public void GivenZeroComplex_thenRealPartZeroAndImagPartZero() {
+	public void givenZeroComplex_thenRealPartZeroAndImagPartZero() {
 		assertEquals(0, zero.getRealPart(), 0.001);
 		assertEquals(0, zero.getImaginaryPart(), 0.001);
 	}
 
 	@Test
-	public void GivenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {
+	public void givenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {
 
 		assertEquals(new Complex(1, 1), zero.add(new Complex(1, 1)));
 	}
 
 	@Test
-	public void GivenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {
+	public void givenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {
 
 		assertEquals(new Complex(1, 1), (new Complex(1, 1)).add(zero));
 	}
diff --git a/tema1_2_ejer4/src/test/java/es/codeurjc/test/complex/ComplexTest.java b/tema1_2_ejer4/src/test/java/es/codeurjc/test/complex/ComplexTest.java
@@ -15,19 +15,19 @@ public void setUp() {
 	}
 
 	@Test
-	public void GivenZeroComplex_thenRealPartZeroAndImagPartZero() {
+	public void givenZeroComplex_thenRealPartZeroAndImagPartZero() {
 		assertEquals(0, zero.getRealPart(), 0.001);
 		assertEquals(0, zero.getImaginaryPart(), 0.001);
 	}
 
 	@Test
-	public void GivenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {
+	public void givenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {
 
 		assertEquals(new Complex(1, 1), zero.add(new Complex(1, 1)));
 	}
 
 	@Test
-	public void GivenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {
+	public void givenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {
 
 		assertEquals(new Complex(1, 1), (new Complex(1, 1)).add(zero));
 	}
diff --git a/tema1_2_ejer5/src/test/java/es/codeurjc/test/complex/ComplexTest.java b/tema1_2_ejer5/src/test/java/es/codeurjc/test/complex/ComplexTest.java
@@ -16,29 +16,32 @@ public void setUp() {
 	}
 
 	@Test
-	public void GivenZeroComplex_thenRealPartZeroAndImagPartZero() {
+	public void givenZeroComplex_thenRealPartZeroAndImagPartZero() {
 		assertEquals(0, zero.getRealPart(), 0.001);
 		assertEquals(0, zero.getImaginaryPart(), 0.001);
 	}
 
 	@Test
-	public void GivenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {
+	public void givenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {
 
 		assertEquals(new Complex(1, 1), zero.add(new Complex(1, 1)));
 	}
 
 	@Test
-	public void GivenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {
+	public void givenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {
 
 		assertEquals(new Complex(1, 1), (new Complex(1, 1)).add(zero));
 	}
 	
 	@Test
-	public void GivenComplex0_0_whenReciprocal_thenExceptionIsThrown() {
+	public void givenComplex0_0_whenReciprocal_thenExceptionIsThrown() {
+
+		ArithmeticException actual = assertThrows(ArithmeticException.class, () -> {
+			
+			zero.reciprocal();
+			
+		});
 
-		ArithmeticException actual = 
-				assertThrows(ArithmeticException.class, () -> zero.reciprocal());
-	
 		assertEquals(actual.getMessage(), "division by zero");
 	}
 }
diff --git a/tema1_2_ejer6/src/test/java/es/codeurjc/test/complex/ComplexTest.java b/tema1_2_ejer6/src/test/java/es/codeurjc/test/complex/ComplexTest.java
@@ -18,32 +18,33 @@ public void setUp() {
 	}
 
 	@Test
-	public void GivenZeroComplex_thenRealPartZeroAndImagPartZero() {
+	public void givenZeroComplex_thenRealPartZeroAndImagPartZero() {
 		assertThat(zero.getRealPart(), equalTo(0.0));
 		assertThat(zero.getImaginaryPart(), equalTo(0.0));
 	}
 
 	@Test
-	public void GivenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {
+	public void givenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {
 
 		assertThat(zero.add(new Complex(1, 1)), equalTo(new Complex(1, 1)));
 	}
 
 	@Test
-	public void GivenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {
+	public void givenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {
 
 		assertThat((new Complex(1, 1)).add(zero),equalTo(new Complex(1, 1)));
 	}
 	
 	@Test
-	public void GivenComplex0_0_whenReciprocal_thenExceptionIsThrown() {
+	public void givenComplex0_0_whenReciprocal_thenExceptionIsThrown() {
 		
-		Complex zero = new Complex(0,0);
+		ArithmeticException actual = assertThrows(ArithmeticException.class, () -> {
+			
+			zero.reciprocal();
+			
+		});
 		
-		ArithmeticException e = 
-				assertThrows(ArithmeticException.class, 
-						() -> zero.reciprocal());
-		assertThat(e.getMessage(), containsString("division by zero"));
+		assertThat(actual.getMessage(), containsString("division by zero"));
 		
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -15,19 +15,19 @@ public void setUp() {`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`@Test`
`18`		`- public void GivenZeroComplex_thenRealPartZeroAndImagPartZero() {`
	`18`	`+ public void givenZeroComplex_thenRealPartZeroAndImagPartZero() {`
`19`	`19`	`assertEquals(0, zero.getRealPart(), 0.001);`
`20`	`20`	`assertEquals(0, zero.getImaginaryPart(), 0.001);`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`@Test`
`24`		`- public void GivenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {`
	`24`	`+ public void givenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {`
`25`	`25`
`26`	`26`	`assertEquals(new Complex(1, 1), zero.add(new Complex(1, 1)));`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`@Test`
`30`		`- public void GivenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {`
	`30`	`+ public void givenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {`
`31`	`31`
`32`	`32`	`assertEquals(new Complex(1, 1), (new Complex(1, 1)).add(zero));`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,29 +16,32 @@ public void setUp() {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`@Test`
`19`		`- public void GivenZeroComplex_thenRealPartZeroAndImagPartZero() {`
	`19`	`+ public void givenZeroComplex_thenRealPartZeroAndImagPartZero() {`
`20`	`20`	`assertEquals(0, zero.getRealPart(), 0.001);`
`21`	`21`	`assertEquals(0, zero.getImaginaryPart(), 0.001);`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`@Test`
`25`		`- public void GivenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {`
	`25`	`+ public void givenZeroComplex_whenAddToComplex1_1_thenComplex1_1IsObtained() {`
`26`	`26`
`27`	`27`	`assertEquals(new Complex(1, 1), zero.add(new Complex(1, 1)));`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`@Test`
`31`		`- public void GivenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {`
	`31`	`+ public void givenComplex1_1_whenAddToZero_thenComplex1_1IsObtained() {`
`32`	`32`
`33`	`33`	`assertEquals(new Complex(1, 1), (new Complex(1, 1)).add(zero));`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`@Test`
`37`		`- public void GivenComplex0_0_whenReciprocal_thenExceptionIsThrown() {`
	`37`	`+ public void givenComplex0_0_whenReciprocal_thenExceptionIsThrown() {`
	`38`	`+`
	`39`	`+ ArithmeticException actual = assertThrows(ArithmeticException.class, () -> {`
	`40`	`+`
	`41`	`+ zero.reciprocal();`
	`42`	`+`
	`43`	`+ });`
`38`	`44`
`39`		`- ArithmeticException actual =`
`40`		`- assertThrows(ArithmeticException.class, () -> zero.reciprocal());`
`41`		`-`
`42`	`45`	`assertEquals(actual.getMessage(), "division by zero");`
`43`	`46`	`}`
`44`	`47`	`}`