Replies: 10 comments 11 replies
-
|
This is most likely because So you effectively overriding it, which means the other tasks in all the inherited modules that depend on If your |
Beta Was this translation helpful? Give feedback.
-
|
I updated example little bit to remove unnecessary calls to highlight usage pattern. Anyway, I think while It has much sense technically but from Mill user perspective its very strange behavior because is hard to expect that small change in single module could lead to significant build process changes in unrelated base modules especially because you might not have visibility of that wiring like with 'scalablytyped' case (in that example is no direct relation between 'assembly' and scalablytyped plugin, but it's build process is affected). |
Beta Was this translation helpful? Give feedback.
-
|
If you can update to Mill 1.1.2, there's been some improvements to the mill-invalidation-tree.json file that should hopefully give moer insight into what is going on |
Beta Was this translation helpful? Give feedback.
-
|
I've updated the repo to use mill 1.1.2. I copied in new output too, but the only difference was the timing. The json file appears to be unchanged |
Beta Was this translation helpful? Give feedback.
-
|
@malcolmredheron could you minimize it further |
Beta Was this translation helpful? Give feedback.
-
|
Is it enough for you just not to use nix? If you already have java in your path you should be fine to ignore nix
…On Tue, Feb 10 2026 at 18:29 , Li Haoyi < ***@***.*** > wrote:
e.g. remove the Nix stuff
—
Reply to this email directly, view it on GitHub (
#6462 (reply in thread)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAAOIXLPCUTWPQLIVVKN6JD4LKHZJAVCNFSM6AAAAACUQTTSDWVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTKNZWGM2DCMY
).
You are receiving this because you were mentioned. Message ID: <com-lihaoyi/mill/repo-discussions/6462/comments/15763413
@ github. com>
|
Beta Was this translation helpful? Give feedback.
-
|
Ok. That repo now uses mill 1.1.2 with whatever jvm mill chooses |
Beta Was this translation helpful? Give feedback.
-
|
I think that we can simplify this more, Strobe. Let's sync up outside this thread
…On Wed, Feb 11, 2026 at 6:16 AM, strobe < ***@***.*** > wrote:
only non standard step there is call of./mill shared.npmInstall which
required to install js dependencies from shared/package.json.
As mention in readme nix stuff is fully only optional, it was included to
provide clear point of reference for 'nodejs' version been used.
—
Reply to this email directly, view it on GitHub (
#6462 (reply in thread)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAAOIXITORXJ7YSYCPBPYC34LM2UDAVCNFSM6AAAAACUQTTSDWVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTKNZXGAYDQMI
).
You are receiving this because you were mentioned. Message ID: <com-lihaoyi/mill/repo-discussions/6462/comments/15770081
@ github. com>
|
Beta Was this translation helpful? Give feedback.
-
|
Ok. This is minimal now. If you look in the readme, you'll see that there are actually two changes that avoid the surprising rebuild of scalablyTyped:
* What we've been discussing so far — renaming app.assembly to app.assemblyX
* The new one: comment out println(shared.hello) in app.assembly
Thank you for all of your attention!
…On Wed, Feb 11, 2026 at 11:07 AM, malcolm handley < ***@***.*** > wrote:
I think that we can simplify this more, Strobe. Let's sync up outside this
thread
On Wed, Feb 11, 2026 at 6:16 AM, strobe < notifications@ github. com (
***@***.*** ) > wrote:
>
>
> only non standard step there is call of./mill shared.npmInstall which
> required to install js dependencies from shared/package.json.
>
>
>
> As mention in readme nix stuff is fully only optional, it was included to
> provide clear point of reference for 'nodejs' version been used.
>
>
>
> —
> Reply to this email directly, view it on GitHub (
> #6462 (reply in thread)
> ) , or unsubscribe (
> https://github.com/notifications/unsubscribe-auth/AAAOIXITORXJ7YSYCPBPYC34LM2UDAVCNFSM6AAAAACUQTTSDWVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTKNZXGAYDQMI
> ).
> You are receiving this because you were mentioned. Message ID: <com-lihaoyi/mill/repo-discussions/6462/comments/15770081
> @ github. com>
>
>
>
|
Beta Was this translation helpful? Give feedback.
-
|
@malcolmredheron looks like the problem was you had a |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Recently we got strange issue with tasks graph invalidation in ScalaJS project which caused build to took more time that is should.
After some digging I was able to reduce this case to minimal reproducible example https://github.com/american-fable/demo-mill-assembly-invalidation-issue (see README.md it has instruction how to reproduce issue).
In short for unknown reason if task has name 'assembly' it causing to invalidate dependent tasks without any changes in those tasks but if different name is used for same task it won't invalidate those as it should be.
(tested on 1.0.6-jvm)
Beta Was this translation helpful? Give feedback.
All reactions