Skip to content

Go SDK README has a typo in example code: 'person_to_be_greated' #27

@nthmost-orkes

Description

@nthmost-orkes

Problem

The Go SDK README (and the underlying example code) uses "person_to_be_greated" as a field name — missing the second 'e' in "greeted":

```go
greet := workflow.NewSimpleTask("greet", "greet_ref").
Input("person_to_be_greated", "${workflow.input.name}")
```

The README even acknowledges it:

"person_to_be_greated is too verbose! Why would you name it like that?"

But the note explains the intentional verbosity, not the typo. The misspelling is present throughout the README and the example code, meaning every new Go user who copies this example ships a typo into their codebase.

Fix

Rename to person_to_be_greeted in both the README and examples/hello_world/.

Affects

  • conductor-oss/go-sdk README
  • conductor-oss/go-sdk examples/hello_world/

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions