Skip to content

Correct exception type #1042

@delacry

Description

@delacry

Hi, shouldn't \Ublaboo\DataGrid\Exception\DataGridException extend \LogicException instead of \Exception?

Because I don't want to propagate nor catch those exceptions, they appear to be in methods like setSortable or setRenderer and my IDE (PhpStorm) is always reporting there is exception that is not handled, but those kind of exceptions are logic exceptions, only if there is a serious bug caused by code, the exceptions should be thrown, and there is no reason to catch them, only avoid them.

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Triage: Now

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions