-
-
Notifications
You must be signed in to change notification settings - Fork 363
Open
Description
Issue:
On a fresh machine (where node-windows has never run before), if I initiate two or more installs (of different services) simultaneously, we see an intermittent issue where:
- For one or more installs, fs.exists () does not find the daemon folder (because nod-windows has not been run yet and daemon folder is actually not there).
Line 540 in 27779d9
fs.exists(dir, function (exists) { - Since fs.exists is async (also deprecated), all calls in step 1 will try to create the daemon folder.
- This leads to a collision where all the installs after the first one (whoever gets to create daemon folder) will fail with an error saying daemon folder already exists.
How To Reproduce:
Give multiple install commands simultaneously.
Expected Behavior:
daemon folder should be created without errors and services should get installed.
Desktop:
- OS: Windows 11
Probable Fix:
We should be using the fs.existsSync function instead of fs.exists at
Line 540 in 27779d9
| fs.exists(dir, function (exists) { |
@coreybutler if you want, I can raise a PR with this fix
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels